Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @solana/web3.js from 1.75.0 to 1.91.6 in /packages/canvas-node #7485

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 17, 2024

Bumps @solana/web3.js from 1.75.0 to 1.91.6.

Release notes

Sourced from @​solana/web3.js's releases.

v1.91.6

1.91.6 (2024-04-17)

Bug Fixes

  • revert use of internal fast-stable-stringify in legacy library (#2509) (7d3adbb)

v1.91.5

1.91.5 (2024-04-17)

Bug Fixes

  • use our version of fast-stable-stringify everywhere (#2504) (18d6b56)

v1.91.4

1.91.4 (2024-04-03)

Bug Fixes

  • downshift preflightCommitment to processed when bypassing preflight checks (#2415) (c801637)

v1.91.3

1.91.3 (2024-04-01)

Bug Fixes

v1.91.2

1.91.2 (2024-03-26)

Reverts

v1.91.1

1.91.1 (2024-03-13)

Bug Fixes

  • splice bytes in-place when reading buffers (#2315) (650707b)

v1.91.0

1.91.0 (2024-03-07)

... (truncated)

Commits
  • 7d3adbb fix: revert use of internal fast-stable-stringify in legacy library (#2509)
  • d4a93ce chore: bump @​babel/plugin-transform-private-property-in-object (#2431)
  • 18d6b56 fix: use our version of fast-stable-stringify everywhere (#2504)
  • e4475ef Format README of @solana/fast-stable-stringify (#2503)
  • 5ed19c6 Add types to @solana/fast-stable-stringify (#2502)
  • f396267 Copy over fast-stable-stringify tests from source (#2501)
  • 0bcc0ca chore: bump @​babel/plugin-transform-runtime from 7.23.7 to 7.24.3 (#2432)
  • 51216ee Restore original author to license file for @solana/fast-stable-stringify (...
  • 96a4894 Actually run CI on the right versions of Node (#2499)
  • 82c57c6 Use native WebSocket in server runtimes that support it (#2500)
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by lorisleiva, a new releaser for @​solana/web3.js since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [@solana/web3.js](https://github.com/solana-labs/solana-web3.js) from 1.75.0 to 1.91.6.
- [Release notes](https://github.com/solana-labs/solana-web3.js/releases)
- [Commits](solana-labs/solana-web3.js@v1.75.0...v1.91.6)

---
updated-dependencies:
- dependency-name: "@solana/web3.js"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 17, 2024
@timolegros
Copy link
Collaborator

timolegros commented Apr 19, 2024

What is this (packages/canvas-node) package even doing in CW? I don't see us importing anything from it and it's not deployed on Heroku, not to mention that it's all in Javascript. Do we actually need this in our repo @raykyri?

@ForestMars ForestMars requested review from ianrowan and removed request for timolegros April 19, 2024 17:53
@raykyri
Copy link
Collaborator

raykyri commented Apr 19, 2024 via email

@timolegros
Copy link
Collaborator

It’s not being used right now, but we’re going to rewrite it once Bob and my PRs are in over the first couple of weeks of May. Can remove it if it would help resolve dependencies or just keep it around till the rewriteOn Apr 19, 2024, at 1:49 PM, Timothee Legros @.> wrote: What is this (packages/canvas-node) package even doing in CW? I don't see us importing anything from it and it's not deployed on Heroku. Do we actually need this @raykyri —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.>

Ok. What will it do once you guys work on it? Will Common team be responsible for deploying this anywhere? Will we need to import from it in other packages? Will it depend on Common models/objects? Basically just want to understand why this exists and will exist in our repo.

@raykyri
Copy link
Collaborator

raykyri commented Apr 19, 2024

It'll expose a sync API that - depending PRD discussions with Zak, Dillon, and a few others over the next couple of days - allows federated clients to sync signed data to/from Commonwealth. It'll probably be necessary to set up a worker process to run the node. That will really just be another entry in the Procfile in packages/commonwealth.

The way that it'll interface with models and the database is via hooks to/from controller code. So maybe there will be some refactoring of controllers inside server/routes/{threads, comments, reactions, etc.}/* so those controllers can be called via the Canvas sync API. We'll document that as well (and ideally work with an engineer on reviewing those docs).

@timolegros
Copy link
Collaborator

It'll expose a sync API that - depending PRD discussions with Zak, Dillon, and a few others over the next couple of days - allows federated clients to sync signed data to/from Commonwealth. It'll probably be necessary to set up a worker process to run the node. That will really just be another entry in the Procfile in packages/commonwealth.

The way that it'll interface with models and the database is via hooks to/from controller code. So maybe there will be some refactoring of controllers inside server/routes/{threads, comments, reactions, etc.}/* so those controllers can be called via the Canvas sync API. We'll document that as well (and ideally work with an engineer on reviewing those docs).

Nice ok. BTW it will probably need to be a separate app -> workers aren't open to external API requests and a Heroku app can only have 1 web dyno.

@raykyri
Copy link
Collaborator

raykyri commented Apr 19, 2024

Oh yea you're right about that. Usually we have a proxy but a separate app probably makes more sense here.

@raykyri raykyri merged commit 89ec335 into master Apr 19, 2024
8 checks passed
@raykyri raykyri deleted the dependabot/npm_and_yarn/packages/canvas-node/solana/web3.js-1.91.6 branch April 19, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants