Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1155 NFT URI Endpoint and setter + Base deployment config #6694

Merged
merged 8 commits into from
Feb 15, 2024
Merged

1155 NFT URI Endpoint and setter + Base deployment config #6694

merged 8 commits into from
Feb 15, 2024

Conversation

ianrowan
Copy link
Contributor

@ianrowan ianrowan commented Feb 9, 2024 •
edited
Loading

Link to Issue

Closes: #6681

Description of Changes

  • Adds endpoint to serve json to public with ERC1155 schema
  • Adds uri construction to namespace helper
  • updates ABI
  • Refactors sepolia -> base
  • sets a base scalar of 100000000
  • adds nft addition to buy stake

Test Plan

  • Create Community flow on demo using base as network
  • buy/sell stake in created community

Deployment Plan

  1. should be deployed when contract updates have also been deployed

Other Considerations

  • Will break with current contracts
  • will only work on production as the commonwealth endpoint is hardcoded
    -NOTE: MERGING/DEPLOYING WILL POINT TO LIVE BASE CONTRACTS

@ianrowan ianrowan linked an issue Feb 9, 2024 that may be closed by this pull request
Metadata creation and endpoint for CS tokens #6681
Closed
@ianrowan ianrowan marked this pull request as draft February 9, 2024 17:57
@ianrowan ianrowan changed the title 1155 NFT URI Endpoint and setter 1155 NFT URI Endpoint and setter + Base deployment config Feb 14, 2024
@ianrowan ianrowan temporarily deployed to commonwealth-demo February 14, 2024 21:33 Inactive
@ianrowan ianrowan marked this pull request as ready for review February 14, 2024 22:35
@ianrowan ianrowan temporarily deployed to commonwealth-demo February 15, 2024 15:41 Inactive
@ianrowan ianrowan temporarily deployed to commonwealth-demo February 15, 2024 16:00 Inactive
@ianrowan ianrowan mentioned this pull request Feb 15, 2024
Closed
mhagel
mhagel reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@mhagel mhagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about scalar. 1 merge conflict to clean up.

packages/commonwealth/client/scripts/helpers/ContractHelpers/NamespaceFactory.ts Show resolved Hide resolved
mhagel
mhagel approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@mhagel mhagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnaviask jnaviask merged commit 242e493 into master Feb 15, 2024
6 of 7 checks passed
@jnaviask jnaviask deleted the 6681-metadata-endpoint-for-cs-tokens branch February 15, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhagel mhagel mhagel approved these changes

@kurtisassad kurtisassad kurtisassad approved these changes

@masvelio masvelio Awaiting requested review from masvelio

@jnaviask jnaviask Awaiting requested review from jnaviask

@timolegros timolegros Awaiting requested review from timolegros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metadata creation and endpoint for CS tokens
4 participants
@ianrowan @mhagel @kurtisassad @jnaviask