Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6511 : Update Editor Component UI - Toolbar Links, Code, and Blockquotes #6603

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

Miaplacidus
Copy link
Contributor

@Miaplacidus Miaplacidus commented Feb 6, 2024

This PR updates the toolbar icons for creating blockquotes, links, and codeblocks in the editor.

Note that the editor is still being worked on, so will still have elements that are updated in other cards.

Link to Issue

Closes: #6511

Description of Changes

  • updates the icons used for blockquotes, links, and codeblocks

Test Plan

  • go to the create thread page
  • confirm expected behavior and style for the aforementioned icons

@Miaplacidus Miaplacidus marked this pull request as ready for review February 6, 2024 20:10
Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. similarly to other issues, when you use code icon, the cursor lands after the inserted code, instead in the middle
    image

  2. is this what product team expects to happen after clicking link icon?
    image

@Miaplacidus
Copy link
Contributor Author

@masvelio
The handing of cursor placement for all editor cards is left to #6614 and other cursor placement-related cards.
Since that is the current functionality of the link button and they have not specified otherwise, I would say so. If they want to update that functionality further, that's going to need to be in a different ticket and PR.

@zakhap @jessmart1213

@Miaplacidus Miaplacidus changed the title update icons for blockquotes, links, and code blocks #6511 : Update Editor Component UI - Toolbar Links, Code, and Blockquotes Feb 7, 2024
Copy link
Collaborator

@Israellund Israellund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Miaplacidus Miaplacidus merged commit 2ffaec7 into master Feb 7, 2024
5 of 7 checks passed
@Miaplacidus Miaplacidus deleted the 6511.ifu.editor-links-code-bquotes branch February 7, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Editor Component UI - Toolbar Links, Code, and Blockquotes
3 participants