-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disconnect all addresses #10177
base: master
Are you sure you want to change the base?
Disconnect all addresses #10177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a new trpc route. Plz move it to the libs/model, there are sample route implementations there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was getting a lot of errors on both disconnecting and deleting addresses. There are many cases that we should probably handle in better way UX wise.
Some errors example I was getting:
"Community must have at least 1 admin. Please assign another community member as admin, to leave this community."
"Cannot delete Magic Link address"
Kapture.2024-12-12.at.10.49.08.mp4
{address.community.id}. Your contributions and comments will remain. | ||
Don't worry, you can rejoin anytime. | ||
{isBulkDelete | ||
? `By leaving ${address?.community.id} you will disconnect all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally it should be community name instead of id
Link to Issue
Closes: #8711
Description of Changes
"How We Fixed It"
Test Plan
Deployment Plan
Other Considerations