-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added uniswap trade widget #10148
Merged
Merged
Added uniswap trade widget #10148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzparacha
commented
Dec 10, 2024
...wealth/client/scripts/views/modals/TradeTokenModel/UniswapTradeModal/useUniswapTradeModal.ts
Show resolved
Hide resolved
burtonator
approved these changes
Dec 11, 2024
masvelio
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm, tested and works according to the test plan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9887
Description of Changes
Added uniswap trade widget to trade tokens post launchpad phase. Trading will not work on tokens launched via common as they are launched on base sepolia, while the modal will use base network, it will only work for the tokens that are already on base. In our implementation, we added
USDT
,USDC
,WETH
as token swap options."How We Fixed It"
N/A
Test Plan
Note: Custom tokens launched via common will not be tradeable via the uniswap modal.
Pre-req
Steps
Screen.Recording.2024-12-10.at.6.17.38.PM.mov
Deployment Plan
N/A
Other Considerations
N/A