Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commented out CD flow for external API #10099

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Commented out CD flow for external API #10099

merged 1 commit into from
Dec 3, 2024

Conversation

kurtisassad
Copy link
Contributor

Link to Issue

Closes: Hotfix

Description of Changes

  • openapi diff is hanging blocking release. Commented it out for now (This will disable auto updating of external api client)

Other Considerations

@github-actions github-actions bot marked this pull request as draft December 3, 2024 19:07
@kurtisassad kurtisassad marked this pull request as ready for review December 3, 2024 19:09
Rotorsoft
Rotorsoft approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@Rotorsoft Rotorsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the only side effect here is freezing API releases, not a big deal right now

@kurtisassad kurtisassad merged commit 095cff6 into master Dec 3, 2024
11 checks passed
@kurtisassad kurtisassad deleted the ka.CDFix branch December 3, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbennettcw rbennettcw rbennettcw approved these changes

@Rotorsoft Rotorsoft Rotorsoft approved these changes

@timolegros timolegros Awaiting requested review from timolegros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kurtisassad @Rotorsoft @rbennettcw