Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking create thread on a contest topic doesn't populate the desired topic at first. #10075

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clicking create thread on a contest topic doesn't populate the desired topic at first. #10075

wants to merge 2 commits into from
+29 −21

Conversation

salman-neslit
Copy link
Collaborator

@salman-neslit salman-neslit commented Dec 2, 2024 •
edited
Loading

Link to Issue

Closes: #10029

Description of Changes

  • Updated the default topic logic in useNewThreadForm to ensure the thread topic state updates.

"How We Fixed It"

Test Plan

  • Navigate to the discussion Page.
  • Select the Contest Topic.
  • Click "Create thread".
  • Verify that the topic is selected.
  • Also repeat the above steps with the FF "newEditor" turned on for the new Editor.

Deployment Plan

Other Considerations

@salman-neslit salman-neslit marked this pull request as ready for review December 2, 2024 22:14
@salman-neslit salman-neslit changed the title [Bug]: Clicking create thread on a contest topic doesn't populate the desired topic at first. [Bug Fix]: Clicking create thread on a contest topic doesn't populate the desired topic at first. Dec 2, 2024
@salman-neslit salman-neslit changed the title [Bug Fix]: Clicking create thread on a contest topic doesn't populate the desired topic at first. Clicking create thread on a contest topic doesn't populate the desired topic at first. Dec 2, 2024
masvelio
masvelio reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@masvelio masvelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unfortunately we need to support to versions of this component so please add it also to the new one. Check newEditor feature flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Israellund Israellund Awaiting requested review from Israellund

@mzparacha mzparacha Awaiting requested review from mzparacha

@masvelio masvelio Awaiting requested review from masvelio

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Clicking create thread on a contest topic doesn't populate the desired topic at first.
2 participants
@salman-neslit @masvelio