Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pressing enter no longer freezes page #10059

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

pressing enter no longer freezes page #10059

wants to merge 1 commit into from

Conversation

Israellund
Copy link
Collaborator

Link to Issue

Closes: #10058

Description of Changes

  • when a user presses enter on the main search bar it no longer freezes the site

"How We Fixed It"

added e.preventDefault() and e.stopPropagation() to functions handling the search input

Test Plan

  • go to the dashboard and search anything in the Search Common search bar
  • confirm that the site no longer freezes and you are still able to navigate around the site

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burtonator burtonator Awaiting requested review from burtonator

@masvelio masvelio Awaiting requested review from masvelio

@mzparacha mzparacha Awaiting requested review from mzparacha

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enter on search bar freezes page
1 participant
@Israellund