Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft: sticky editor #10055

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

draft: sticky editor #10055

wants to merge 20 commits into from

Conversation

burtonator
Copy link
Collaborator

@burtonator burtonator commented Nov 27, 2024

Link to Issue

Closes: #10008

Description of Changes

  • new flag FLAG_STICKY_EDITOR will turn this on.
  • Implements the figma design for sticky comments
  • Here's a video of what the implementation does
CleanShot.2024-11-27.at.13.08.52.mp4

"How We Fixed It"

Test Plan

  • You can create a thread, then try to comment on a thread on mobile and desktop.

Deployment Plan

  • turn on the FLAG_STICKY_EDITOR flag. I tested with the flag on and off and both modes work fine.

Other Considerations

@burtonator burtonator self-assigned this Nov 27, 2024
@burtonator burtonator requested review from masvelio, mzparacha and Israellund and removed request for masvelio and mzparacha November 27, 2024 21:22
@burtonator burtonator marked this pull request as ready for review November 27, 2024 22:12
@burtonator burtonator marked this pull request as draft November 27, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement sticky editor designs
1 participant