Multichain erc20 vote weight + Native ETH voting #10049
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbennettcw
changed the title
masvelio
reviewed
Dec 2, 2024
There was a problem hiding this comment.
-
Change the name of the voting strategy from "Connect ERC 20" to "Use ERC20/ETH"
This one from the ticket is not applied
- Created community on BASE and topic with native address. Vote weight is 0 for me even though I have ~0.22 base eth in my wallet.
- Cant vote on a thread in topic that uses native token.
Kapture.2024-12-02.at.16.44.57.mp4
- There are some TS error around
getTokenErrorin two components
| }); | ||
|
|
||
| console.log({ erc20Balance, userEthBalance }); |
| const nativeTokenMetadata: GetTokenMetadataResponse = { | ||
| decimals: 18, | ||
| logo: '', | ||
| name: 'ETH', // TODO: get native eth name/symbol |
There was a problem hiding this comment.
Are you gonna work on this TODO in this PR? If not, please create ticket and link it here in the comment.
| fullWidth | ||
| tokenError={getTokenError()} | ||
| /> | ||
| <CWCheckbox |
There was a problem hiding this comment.
shouldnt this be only visible (and logic applied) on particular chains
per ticket:
If community is on Base or ETH, there will be a checkbox field beneath the token address field. This field would say "use native token"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9849
Closes: #9927
Description of Changes
Test Plan
Deployment Plan
N/A
Other Considerations