Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redesign the community card in home page #10040

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

redesign the community card in home page #10040

wants to merge 4 commits into from

Conversation

KaleemNeslit
Copy link
Collaborator

Link to Issue

Closes: #9984

Description of Changes

  • Update the Trending Communities card in Homepage
  • now user can join the community from the card

"How We Fixed It"

  • Update the Trending Communities card in Homepage
  • now user can join the community from the card

Test Plan

In home screen look for Trending Communities in right side you will be able to join community from there if not already joined

mzparacha
mzparacha reviewed Nov 27, 2024
View reviewed changes
...ages/user_dashboard/TrendingCommunitiesPreview/CommunityPreviewCard/CommunityPreviewCard.tsx Outdated
monthlyThreadCount?: number;
isCommunityMember?: boolean;
hasNewContent?: boolean;
onClick?: () => any;
isExploreMode?: boolean;
};
} & (
| { isExploreMode: true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz move community?: from above here

@mzparacha
Copy link
Contributor

  1. For communities with larger names, i get some overflows
image
  1. If a click on "Join community" button when non-auth state, can we make it "User click -> auth modal opens -> user logs in -> user joins community"? There is a useDeferredConditionTriggerCallback hook that is specifically built for this purpose.
Screen.Recording.2024-11-27.at.6.59.22.PM.mov
  1. lets add some pad b/w the thread/m and "new" tag
image

@masvelio
Copy link
Contributor

  1. Please always check your PRS how it is looking on mobile. Our common approach is truncating names to 1 or max 2 lines. Use multiline-text-ellipsis
    image

@Israellund
Copy link
Collaborator

@KaleemNeslit You could maybe use smartTrim() to dictate the length of the community names so they don't mess with the design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzparacha mzparacha mzparacha left review comments

@masvelio masvelio Awaiting requested review from masvelio

@Israellund Israellund Awaiting requested review from Israellund

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Community card
4 participants
@KaleemNeslit @mzparacha @masvelio @Israellund