Added open magic wallet functionality #10019
Open
+795
−193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Israellund
requested review from
burtonator,
dillchen,
masvelio and
mzparacha
mzparacha
reviewed
Dec 2, 2024
Comment on lines
+60
to
+67
| const openMagicWallet = async () => { | ||
| try { | ||
| await magic.wallet.showUI(); | ||
| } catch (error) { | ||
| console.trace(error); | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
can we move this to useAuthentication?
mzparacha
reviewed
Dec 2, 2024
| @@ -25,6 +25,8 @@ const UpdateCustomDomainTask = () => { | |||
| buttonType: 'destructive', | |||
| buttonHeight: 'sm', | |||
| onClick: () => { | |||
| console.log('communityId', communityId); | |||
| console.log('customDomain', customDomain); | |||
mzparacha
reviewed
Dec 2, 2024
Comment on lines
+259
to
+266
| const openMagicWallet = async () => { | ||
| try { | ||
| await magic.wallet.showUI(); | ||
| } catch (error) { | ||
| console.trace(error); | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
lets move this to useAuthentication
mzparacha
reviewed
Dec 2, 2024
Comment on lines
+136
to
+137
| const userData = useUserStore(); | ||
| const hasMagic = userData.addresses?.[0]?.walletId === WalletId.Magic; |
mzparacha
reviewed
Dec 2, 2024
Comment on lines
+71
to
+76
| case WelcomeOnboardModalSteps.MagicWallet: { | ||
| return { | ||
| index: 4, | ||
| title: 'Magic Wallet Creation', | ||
| component: ( | ||
| <MagicWalletCreationStep |
There was a problem hiding this comment.
magic wallets are only made for sms + other sso methods right? If yes shouldn't this be displayed conditionally when a signup with one of those method happens?
mzparacha
reviewed
Dec 2, 2024
| @@ -83,6 +83,8 @@ export enum WalletSsoSource { | |||
| Twitter = 'twitter', | |||
| Apple = 'apple', | |||
| Email = 'email', | |||
| Farcaster = 'farcaster', | |||
There was a problem hiding this comment.
is farcaster logic a part of this pr?
There was a problem hiding this comment.
@mzparacha this branch was made off of a branch Kurtis made, at the request of Dillon. So I believe that is a change he made.
mzparacha
reviewed
Dec 2, 2024
Comment on lines
+168
to
+175
| const openMagicWallet = async () => { | ||
| try { | ||
| await magic.wallet.showUI(); | ||
| } catch (error) { | ||
| console.trace(error); | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
move to useAuthentication
mzparacha
approved these changes
Dec 2, 2024
ianrowan
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #5309
Description of Changes
NOTE: I made these changes based off of the Figma designs. I tried desperately to embed the widget in the account creation modal as was shown in the original designs, but unfortunately widget's don't work that way. Sabina and I decided to simply replace it with an image and change the copy telling the user where they can access their magic wallet
Test Plan