Merge pull request #9902 from hicommonwealth/ci_fixes_for_release

fix: update reaction deletion logic and improve test assertions
hicommonwealth · Nov 14, 2024 · 6b07853 · 6b07853
2 parents 33662b6 + 6c0bbb5
commit 6b07853
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/packages/commonwealth/client/scripts/state/api/comments/deleteReaction.ts b/packages/commonwealth/client/scripts/state/api/comments/deleteReaction.ts
@@ -63,9 +63,7 @@ const useDeleteCommentReactionMutation = ({
           if (comment.id === commentId) {
             return {
               ...comment,
-              reactions: comment.reactions.filter(
-                (r) => r.id !== deleted.reaction_id,
-              ),
+              reactions: comment.reactions.filter((r) => r.id !== deleted.id),
             };
           }
           return comment;

diff --git a/packages/commonwealth/test/integration/api/createReactions.spec.ts b/packages/commonwealth/test/integration/api/createReactions.spec.ts
@@ -146,7 +146,7 @@ describe('createReaction Integration Tests', () => {
       userJWT,
       userAddress,
     );
-    chai.assert.equal(deleteReactionResponse.reaction_id, reactionId);
+    chai.assert.isTrue(deleteReactionResponse);
 
     await comment!.reload();
     chai.assert.equal(comment!.reaction_count, beforeReactionCount);
@@ -184,7 +184,7 @@ describe('createReaction Integration Tests', () => {
       userAddress,
     );
 
-    chai.assert.equal(deleteReactionResponse.reaction_id, reactionId);
+    chai.assert.isTrue(deleteReactionResponse);
 
     await thread!.reload();
     chai.assert.equal(thread!.reaction_count, beforeReactionCount!);