cleaner solution

hicommonwealth · Jun 25, 2024 · 2ae1b70 · 2ae1b70
1 parent 7134cc0
commit 2ae1b70
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/packages/commonwealth/server/routes/getNewProfile.ts b/packages/commonwealth/server/routes/getNewProfile.ts
@@ -44,16 +44,14 @@ const getNewProfile = async (
 ) => {
   const { profileId } = req.query;
 
+  let profile: ProfileInstance;
+
   if (profileId) {
     const parsedInt = parseInt(profileId);
     if (isNaN(parsedInt) || parsedInt !== parseFloat(profileId)) {
       throw new AppError('Invalid profile id');
     }
-  }
 
-  let profile: ProfileInstance;
-
-  if (profileId) {
     // @ts-expect-error StrictNullChecks
     profile = await models.Profile.findOne({
       where: {