Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-14438 - ValueHandlers are broken #3717

Closed
wants to merge 2 commits into from

Conversation

andreybpanfilov
Copy link

@andreybpanfilov andreybpanfilov commented Feb 5, 2021

Base automatically changed from master to main March 19, 2021 16:00
@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Nov 23, 2024

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [6032f3c]

› This message was automatically generated.

@gavinking
Copy link
Member

gavinking commented Nov 23, 2024

There are no ValueHandlers in H6 and H7, and at this point I doubt we're going to fix this in H5.6, since it wasn't a regression. Furthermore, this pull request does not come with a test.

So I'm going to close this, even though the suggested fix looks like it was probably correct.

@sebersole can correct me if this was the wrong action to take here.

@gavinking gavinking closed this Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants