Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mailer configs #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bernd-wechner
Copy link
Contributor

Having configured the mailer, I figure the mailer configs should be in run.sh as well, to make them easily discoverable.
Added a few comments as well and export each variable as it's defined rather than in a separate statement.

@rokdd
Copy link

rokdd commented Feb 3, 2022

I thought that makes no sense, to export the vars when they are not properly set up. So my intention was to make a difference between:

  • default: vars with default values and works also without editing
  • optional: vars which need to be individual set because there is no default

@bernd-wechner
Copy link
Contributor Author

I guess we could comment them out by default. Really just added them heard rather that .joplinrc. Can push a version with commented out lines thoigh one might argue all of the settings should be commented out until set properly. Or maybe the defaults can simply be blank rather than examples, or if the default for MAILER_ENABLED is 0 that might cover everything set it to 1 only once the others have sensible values. Hmm not sure. Not fussed really, was just sharing where I did set them I guess.

Technically, given all run.sh does is set these it could maybe diappear, and the service just runs a config file source then npm --prefix packages/server start. And sample config file is provided. Perhaps the ocnfig file shoudl in fact be /etc/config/joplin Random thoughts. The PR was as much intended to provoke discussion asa anything I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants