Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

增加dml工单影响行数限制，超过限制工单必须拆分小事务提交 #2733

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

增加dml工单影响行数限制，超过限制工单必须拆分小事务提交 #2733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a774f8f
增加dml工单影响行数限制，超过限制工单必须拆分小事务提交
woshiyanghai Jul 18, 2024
7683ebf
修复lint报错
woshiyanghai Jul 18, 2024
7260134
修改前端页面位置
woshiyanghai Jul 19, 2024
724826d
修改前端页面位置
woshiyanghai Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/templates/config.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,16 @@ <h5 style="color: darkgrey"><b>SQL上线</b></h5>
</div>
</div>
</div>
<div class="form-group">
<label for="affected_rows_limit"
class="col-sm-4 control-label">AFFECTED_ROWS_LIMIT</label>
<div class="col-sm-5">
<input type="number" class="form-control" id="affected_rows_limit"
key="affected_rows_limit"
value="{{ config.affected_rows_limit }}"
placeholder="dml影响行数限制，超过行的语句禁止提交,默认100000000" />
</div>
</div>
<div class="form-group">
<label for="ban_self_audit"
class="col-sm-4 control-label">BAN_SELF_AUDIT</label>
Expand Down
14 changes: 14 additions & 0 deletions sql/engines/mysql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,10 +648,14 @@ def execute_check(self, db_name=None, sql=""):
# 禁用/高危语句检查
critical_ddl_regex = self.config.get("critical_ddl_regex", "")
ddl_dml_separation = self.config.get("ddl_dml_separation", False)
affected_rows_limit = int(
self.config.get("affected_rows_limit", 100000000)
) # 影响最大行数限制默认100000000行
p = re.compile(critical_ddl_regex)
# 获取语句类型：DDL或者DML
ddl_dml_flag = ""
for row in check_result.rows:
affected_rows = row.affected_rows
statement = row.sql
# 去除注释
statement = remove_comments(statement, db_type="mysql")
Expand All @@ -669,6 +673,16 @@ def execute_check(self, db_name=None, sql=""):
row.stagestatus = "驳回高危SQL"
row.errlevel = 2
row.errormessage = "禁止提交匹配" + critical_ddl_regex + "条件的语句！"
# dml影响行数超过限制,超过限制的dml必须拆分成小事务才可以提交,建议不打开REAL_ROW_COUNT
elif syntax_type == "DML" and affected_rows > affected_rows_limit:
check_result.error_count += 1
row.stagestatus = "驳回高危SQL"
row.errlevel = 2
row.errormessage = (
"禁止提交匹配生产环境，禁止提交影响行数超过"
+ str(affected_rows_limit)
+ "行的dml语句!"
)
elif ddl_dml_separation and syntax_type in ("DDL", "DML"):
if ddl_dml_flag == "":
ddl_dml_flag = syntax_type
Expand Down
Loading