-
Notifications
You must be signed in to change notification settings - Fork 159
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Rework devcontainer to use proxygen server
This means that `hhvm` is the actual docker command; the bad news is that if hhvm crashes, the container goes down. I'm doing this anyway as there doesn't appear to be support in devcontainer.json for a separate long-running command - only via docker compose, which: - feels like overkill - appears not to support devcontainer variables like containerWorkspaceFolder; this means that it can't work with GitHub codespaces, as the `workspaceMount` devcontainer.json option is not supported on codespaces The lack of support for `workspaceMount` is also why there's the fun messing around with symlinking /var/www and configuration files.
- Loading branch information
1 parent
8dbc0a2
commit b5ca417
Showing
5 changed files
with
24 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
FROM hhvm/hhvm-proxygen:4.134-latest | ||
|
||
ARG WORKSPACE | ||
|
||
RUN rm -rf /var/www; ln -s ${WORKSPACE} /var/www | ||
RUN ln -sf /var/www/hhvm.dev.ini /etc/hhvm/site.ini | ||
RUN touch /docker_build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters