Add linter

.travis.sh

@@ -6,6 +6,7 @@ composer install
 
 hh_client
 hhvm vendor/bin/phpunit
+hhvm vendor/bin/hhast-lint
 
 # Make sure we pass when a release is required
 EXPORT_DIR=$(mktemp -d)

composer.json

@@ -7,7 +7,8 @@
     "hhvm": "^3.23.0",
     "hack-psr/psr7-http-message-hhi": "^0.2.0|^1.0.0",
     "hhvm/hsl": "^1.0.0",
-    "hhvm/hhvm-autoload": "^1.5.3"
+    "hhvm/hhvm-autoload": "^1.5.3",
+    "hhvm/hhast": "^1.0"
   },
   "extra": {
     "branch-alias": {

examples/BaseRouterExample.php

@@ -15,7 +15,7 @@
 
 namespace Facebook\HackRouter\Examples\BaseRouterExample;
 
-require_once('../vendor/autoload.php');
+require_once(__DIR__.'/../vendor/hh_autoload.php');
 
 use Facebook\HackRouter\BaseRouter;
 use Facebook\HackRouter\HttpMethod;
@@ -27,6 +27,7 @@
 type TResponder = (function(dict<string, string>):string);
 
 final class BaseRouterExample extends BaseRouter<TResponder> {
+  <<__Override>>
   protected function getRoutes(
   ): ImmMap<HttpMethod, ImmMap<string, TResponder>> {
     return ImmMap {

examples/UriPatternsExample.php

@@ -15,7 +15,7 @@
 
 namespace Facebook\HackRouter\Examples\UrlPatternsExample;
 
-require_once('../vendor/autoload.php');
+require_once(__DIR__.'/../vendor/hh_autoload.php');
 
 use Facebook\HackRouter\{
   BaseRouter,
@@ -52,22 +52,26 @@ public function __construct(
 }
 
 final class HomePageController extends WebController {
+  <<__Override>>
   public static function getUriPattern(): UriPattern {
     return (new UriPattern())->literal('/');
   }
 
+  <<__Override>>
   public function getResponse(): string {
     return 'Hello, world';
   }
 }
 
 final class UserPageController extends WebController {
+  <<__Override>>
   public static function getUriPattern(): UriPattern {
     return (new UriPattern())
       ->literal('/users/')
       ->string('user_name');
   }
 
+  <<__Override>>
   public function getResponse(): string {
     return 'Hello, '.$this->getRequestParameters()->getString('user_name');
   }

hhast-lint.json

@@ -0,0 +1,4 @@
+{
+  "roots": [ "src/", "tests/", "examples/" ],
+  "builtinLinters": "all"
+}

src/PatternParser/LiteralNode.php

@@ -20,7 +20,7 @@ public function getText(): string {
     return $this->text;
   }
 
-  public function _toStringForDebug(): string {
+  public function toStringForDebug(): string {
     return \var_export($this->getText(), true);
   }
 

src/PatternParser/Node.php

@@ -12,6 +12,6 @@
 namespace Facebook\HackRouter\PatternParser;
 
 interface Node {
-  public function _toStringForDebug(): string;
+  public function toStringForDebug(): string;
   public function asRegexp(string $delimiter): string;
 }

src/PatternParser/OptionalNode.php

@@ -19,8 +19,8 @@ public function getPattern(): PatternNode {
     return $this->pattern;
   }
 
-  public function _toStringForDebug(): string {
-    return '?'.$this->pattern->_toStringForDebug();
+  public function toStringForDebug(): string {
+    return '?'.$this->pattern->toStringForDebug();
   }
 
   public function asRegexp(string $delimiter): string {

src/PatternParser/ParameterNode.php

@@ -25,7 +25,7 @@ public function getRegexp(): ?string {
     return $this->regexp;
   }
 
-  public function _toStringForDebug(): string {
+  public function toStringForDebug(): string {
     $re = $this->getRegexp();
     if ($re === null) {
       return '{'.$this->getName().'}';

src/PatternParser/PatternNode.php

@@ -21,9 +21,9 @@ public function getChildren(): vec<Node> {
     return $this->children;
   }
 
-  public function _toStringForDebug(): string {
+  public function toStringForDebug(): string {
     return $this->children
-      |> Vec\map($$, $child ==> $child->_toStringForDebug())
+      |> Vec\map($$, $child ==> $child->toStringForDebug())
       |> Str\join($$, ', ')
       |> '['.$$.']';
   }

tests/ParserTest.php

@@ -47,7 +47,7 @@ public function getExamplePatterns(): array<(string, string)> {
    * @dataProvider getExamplePatterns
    */
   public function testPattern(string $pattern, string $expected): void {
-    expect(PatternParser\Parser::parse($pattern)->_toStringForDebug())
+    expect(PatternParser\Parser::parse($pattern)->toStringForDebug())
       ->toBeSame($expected);
   }
 }

tests/RouterTest.php

@@ -235,10 +235,13 @@ public function testMethodNotAllowed(): void {
 
   public function testCovariantTResponder(): void {
     $router = $this->getRouter();
-    $this->_testCovariantTResponder($router, $router);
+    $this->typecheckCovariantTResponder($router, $router);
   }
 
-  public function _testCovariantTResponder(BaseRouter<arraykey> $_, BaseRouter<string> $_): void {}
+  private function typecheckCovariantTResponder(
+    BaseRouter<arraykey> $_,
+    BaseRouter<string> $_,
+  ): void {}
 
 
   private function getRouter(