Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix tests #60

Merged
merged 4 commits into from
Feb 18, 2021
Merged

[WIP] Fix tests #60

merged 4 commits into from
Feb 18, 2021

Conversation

andrewgsavage
Copy link
Collaborator

@andrewgsavage andrewgsavage commented Feb 17, 2021

Made a start at getting tests working again.

  • Closes Fixing the tests #52
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file

@hgrecco
Copy link
Owner

hgrecco commented Feb 17, 2021

To run the linters, my suggestion is that you do:

$ pip install pre-commit
$ pre-commit install  # in the pint-pandas git folder
$ pre-commit run --all-files 

I have found that this much more reliable than using black/isort/flake from command line as we were doing this before.

@hgrecco
Copy link
Owner

hgrecco commented Feb 17, 2021

I added a PR template!

@znicholls
Copy link
Contributor

znicholls commented Feb 17, 2021

@andrewgsavage if you think this could be slow, would an easier first step be to just mark things as xfail then we work our way back through bit by bit in subsequent PRs? I'm just concerned that progress will be held up (e.g. my fiddling with pandas is_list_like in #59, I seem to have caught the attention of the pandas devs so am keen to capitalise) if we try and solve everything here (which could be hard).

@znicholls
Copy link
Contributor

We can add 'closes #52' to the description right?

@andrewgsavage
Copy link
Collaborator Author

@andrewgsavage if you think this could be slow, would an easier first step be to just mark things as xfail then we work our way back through bit by bit in subsequent PRs? I'm just concerned that progress will be held up (e.g. my fiddling with pandas is_list_like in #59, I seem to have caught the attention of the pandas devs so am keen to capitalise) if we try and solve everything here (which could be hard).

Yea that's fair, some could take a while and I won't know till I try

@andrewgsavage
Copy link
Collaborator Author

@hgrecco this is ready, will get to the remaining tests in another PR

@hgrecco
Copy link
Owner

hgrecco commented Feb 18, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 18, 2021

Configuration problem:
bors.toml: not found

@hgrecco hgrecco merged commit 4e8ad6f into hgrecco:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing the tests
3 participants