-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix tests #60
[WIP] Fix tests #60
Conversation
To run the linters, my suggestion is that you do:
I have found that this much more reliable than using black/isort/flake from command line as we were doing this before. |
I added a PR template! |
@andrewgsavage if you think this could be slow, would an easier first step be to just mark things as xfail then we work our way back through bit by bit in subsequent PRs? I'm just concerned that progress will be held up (e.g. my fiddling with pandas is_list_like in #59, I seem to have caught the attention of the pandas devs so am keen to capitalise) if we try and solve everything here (which could be hard). |
We can add 'closes #52' to the description right? |
Yea that's fair, some could take a while and I won't know till I try |
@hgrecco this is ready, will get to the remaining tests in another PR |
bors r+ |
Configuration problem: |
Made a start at getting tests working again.
pre-commit run --all-files
with no errors