Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable mypy in pre-commit #215

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Enable mypy in pre-commit #215

merged 4 commits into from
Feb 2, 2024

Commits on Jan 13, 2024

  1. Enable mypy in pre-commit 

    Initial attempt to add mypy to pre-commit actions.

Signed-off-by: Michael Tiemann <[email protected]>
    @MichaelTiemannOSC
    MichaelTiemannOSC committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    f222096 View commit details
    Browse the repository at this point in the history

  2. Update .pre-commit-config.yaml 

    Fix indentation error from copy-paste.

Signed-off-by: Michael Tiemann <[email protected]>
    @MichaelTiemannOSC
    MichaelTiemannOSC committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    fdc27d7 View commit details
    Browse the repository at this point in the history

  3. Final tweaks for clean mypy pass 

    Adjusted various declarations to use public Pandas APIs where possible, ignored things that cannot be fixed without fixing Pandas-Stubs, etc.

Might need some more attention for different versions of Pandas/Python, but this work for Pandas 2.1.4 and Python 3.11.

Signed-off-by: Michael Tiemann <[email protected]>
    @MichaelTiemannOSC
    MichaelTiemannOSC committed Jan 13, 2024
    Configuration menu
    Copy the full SHA
    979fb8f View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2024

  1. Update pint_array.py 

    Make type hints compatible with python-3.9 (which requires `Union` and does not support the `|` operator to express type disjunction).

Signed-off-by: Michael Tiemann <[email protected]>
    @MichaelTiemannOSC
    MichaelTiemannOSC committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    442336d View commit details
    Browse the repository at this point in the history