Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added index.html to tags and archives links #5544

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

majkel89
Copy link

@majkel89 majkel89 commented Sep 8, 2024

What does it do?

Resolves #5543

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

Copy link

github-actions bot commented Sep 8, 2024

How to test

git clone -b all_links_with_index https://github.com/majkel89/hexo.git
cd hexo
npm install
npm test

@majkel89 majkel89 force-pushed the all_links_with_index branch from 5724ae4 to 857f62c Compare September 8, 2024 19:57
Copy link
Member

@uiolee uiolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

INFO  Generated: categories/cat1/index.html/index.html
INFO  Generated: 2024/09/04/title/index.html
INFO  Generated: 2024/06/21/hello-world/index.html
INFO  Generated: tags/tag1/index.html/index.html

This is incorrect for tags and categories. index.html becomes a directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags and Archives links shoud follow permalink configuration
2 participants