Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Hexo): add event emitter descriptor #5302

Merged
merged 2 commits into from
Jan 9, 2024
Merged

chore(Hexo): add event emitter descriptor #5302

merged 2 commits into from
Jan 9, 2024

Conversation

dimaslanjaka
Copy link
Contributor

@dimaslanjaka dimaslanjaka commented Oct 4, 2023 •
edited
Loading

What does it do?

add event emitter description for easily typings on VSCode, Intellij IDEA, or other IDE

Screenshots

image
image
image

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

How to test

git clone -b add-event-emitter-description https://github.com/dimaslanjaka/hexo.git
cd hexo
npm install
npm test

@coveralls
Copy link

coveralls commented Oct 4, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7301039144

  • 82 of 82 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 99.54%
Totals Coverage Status
Change from base Build 7070586365: 0.004%
Covered Lines: 9088
Relevant Lines: 9130
💛 - Coveralls

@stevenjoezhang stevenjoezhang changed the base branch from v7.0.0 to master October 25, 2023 05:01
yoshinorin
yoshinorin approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@yoshinorin yoshinorin merged commit 15dc6ca into hexojs:master Jan 9, 2024
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uiolee uiolee uiolee approved these changes

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dimaslanjaka @coveralls @yoshinorin @uiolee