-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register unpublish cli command to the console #4995
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
👇 Can someone please help with the open CI/CD failures ie all 13 of them? Where do I start in resolving these failures so they all get passed? Thanks! |
Co-authored-by: yoshinorin <[email protected]>
Some tests may fail due to race conditions:
Do we need to fix them? |
But, one of the reasons why I don't approve and merge this PR is I can't understand how to use this command. I pull this PR to my local machine and tried to use it for review. I spent around 1h for try-and-error. Finally, I gave up. Honestly, I also don't know the |
Hi there, Sorry. I'm just catching up on my old PR that's been left open for over 6 months. Can you help me to point out where the errors are failing so I can find and fix them? Thanks. |
@awongCM You can check these failed tests: https://github.com/hexojs/hexo/actions/runs/3619487925/jobs/6127574239 |
I realised where my mistake was... I forgot to follow the contribution guidelines of the I will get this sorted asap. |
How to testgit clone -b unplublish-cli https://github.com/awongCM/hexo.git
cd hexo
npm install
npm test |
Sorry, it's taken a while to get failed test suite fixed. 2023 was a crazy year for me..
Can you please if it's all okay on your end and can be approved for merge, assuming the above merge conflicts can be done by someone else? |
Hi I'm just following on this. Any update or feedback you can provide? Thanks! |
What does it do?
As a long time user of Octopress static site generator, I'm porting one of its useful commands,
unpublish
over there to here.The explanation is simple -
unpublish
will move any published posts from_posts
folder back to the_drafts
folder. This is the reverse operation ofpublish
command.I find this old command feature from Octopress is useful a lot so I thought it would make good use case to have it for Hexo's counterpart. :)
Here's the original Ruby source for it - https://github.com/octopress/octopress/blob/master/lib/octopress/commands/unpublish.rb#L27
and
https://github.com/octopress/octopress/blob/af048361405919605d50fc45e2e1fd0c7eb02703/lib/octopress/post.rb#L37
Pull request tasks