Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hexo 6.0.0 #4750

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Hexo 6.0.0 #4750

merged 1 commit into from
Dec 22, 2021

Conversation

tomap
Copy link
Contributor

@tomap tomap commented Aug 6, 2021

Following the breaking change on list_tags, I propose to release a v6 of Hexo
cf 042f862

I checked, and this was the only commit to release v5: 1489074

I would also suggest to update all dependencies that are not yet updated before releasing v6 (devDependencies)

Anyone wanted to add something to the v6 ?

We should also prepare a blog post to announce the release :)

@coveralls
Copy link

coveralls commented Aug 6, 2021

Coverage Status

Coverage decreased (-0.1%) to 98.147% when pulling 7b6b804 on hexo-6 into 042f862 on master.

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about drop Node 10.x?

#4378

IMHO we should start to drop Node.js 10.x from all repos.

@SukkaW
Copy link
Member

SukkaW commented Aug 7, 2021

I will mark this pr as a proposal. Obviously, it is an opportunity for us to introduce many other breaking changes as well.

@SukkaW
Copy link
Member

SukkaW commented Aug 26, 2021

I will mark this pr as a proposal. Obviously, it is an opportunity for us to introduce many other breaking changes as well.

FYI, I am currently working on replacing RegExp with the state machine for escaping (in backtickcode filter and in post render).

@tomap
Copy link
Contributor Author

tomap commented Aug 26, 2021

Ideally, if we could do this release before Sept 18th, that would be great :)

@stevenjoezhang
Copy link
Member

stevenjoezhang commented Sep 3, 2021

I would suggest to migrate from commonjs to esm in Hexo 6. All dependency packages created by Sindre Sorhus require esm to load.

@tomap
Copy link
Contributor Author

tomap commented Sep 4, 2021

@stevenjoezhang I also think we should do that, but this project will clearly take longer than Sept 18th, so I would recommend doing that in Hexo 7

@stevenjoezhang
Copy link
Member

OK, I replied here as a to-do list #4378 (comment)

@SukkaW
Copy link
Member

SukkaW commented Sep 20, 2021

I will mark this pr as a proposal. Obviously, it is an opportunity for us to introduce many other breaking changes as well.

FYI, I am currently working on replacing RegExp with the state machine for escaping (in backtickcode filter and in post render).

#4780

@github-actions github-actions bot added the stale label Dec 8, 2021
@github-actions github-actions bot closed this Dec 15, 2021
@SukkaW SukkaW reopened this Dec 15, 2021
@tomap
Copy link
Contributor Author

tomap commented Dec 15, 2021

Could we create v6.0, even without #4781 that would allow us to have a fix for the security issue released recently

@SukkaW
Copy link
Member

SukkaW commented Dec 15, 2021

Could we create v6.0, even without #4781 that would allow us to have a fix for the security issue released recently

I have already made an announcement about the CVE: #4838

But yeah, I'd like to have 6.0.0 released ASAP.

Also, we need to address some kind of breaking changes migration guideline for the fix.

@github-actions github-actions bot removed the stale label Dec 16, 2021
@yoshinorin
Copy link
Member

@tomap @SukkaW
Should we merge this PR and release the v6.0.0?
Sorry, I don't know we should publish it or not...

If yes, I can publish a new version.

@tomap
Copy link
Contributor Author

tomap commented Dec 20, 2021

I'm ok with it. We need to prepare an announcement on site also? Before?

@yoshinorin yoshinorin merged commit c749815 into master Dec 22, 2021
@yoshinorin yoshinorin deleted the hexo-6 branch December 22, 2021 13:04
@yoshinorin
Copy link
Member

I'm ok with it. We need to prepare an announcement on site also? Before?

I think after is enough.

@yoshinorin
Copy link
Member

@hexojs/core
Done.
I just published the new version.

https://www.npmjs.com/package/hexo/v/6.0.0
https://github.com/hexojs/hexo/releases/tag/6.0.0

@yoshinorin
Copy link
Member

Also, we need to address some kind of breaking changes migration guideline for the fix.

Does someone please let me know about migration guideline?
Or would you please edit v6.0.0 release note?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants