Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pagination_dir setting #98

Merged
merged 2 commits into from
Jul 8, 2024
Merged

fix: pagination_dir setting #98

merged 2 commits into from
Jul 8, 2024

Conversation

uiolee
Copy link
Member

@uiolee uiolee commented Apr 18, 2024 •
edited
Loading

check list

  • Add test cases for the changes.
  • Passed the CI test.

Description

Additional information

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 818fa98 on page_dir
into f8ef61c on master.

@uiolee uiolee marked this pull request as ready for review July 7, 2024 15:20
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling d7ed8f2 on page_dir
into beaa06c on master.

@yoshinorin yoshinorin merged commit 59aeb87 into master Jul 8, 2024
18 checks passed
@yoshinorin yoshinorin deleted the page_dir branch July 8, 2024 22:47
yoshinorin added a commit that referenced this pull request Jul 8, 2024
@yoshinorin
Revert "fix: pagination_dir setting (#98)"
a6d8a87 
This reverts commit 59aeb87.
@uiolee uiolee mentioned this pull request Jul 9, 2024
Merged
1 task
@soundofautumn soundofautumn mentioned this pull request Jul 9, 2024
Merged
@vasudev-gm vasudev-gm mentioned this pull request Jul 10, 2024
Merged
@Starryi Starryi mentioned this pull request Jul 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

index_generator.pagination_dir doesn't take effect
3 participants
@uiolee @coveralls @yoshinorin