Merge for release 2.3.0

Signed-off-by: Nico Sonack <[email protected]>

.gitlab-ci.yml

@@ -8,9 +8,9 @@ alpine-amd64:
     - linux
   image: alpine:3.17
   script:
-    - apk add libcurl gcc autoconf automake libtool make pkgconf musl-dev curl-dev flex bison xz gzip bzip2 libbsd-dev kyua atf-dev
+    - apk add libcurl gcc autoconf automake libtool make pkgconf musl-dev curl-dev flex bison xz gzip bzip2 libbsd-dev kyua atf-dev libedit-dev
     - ./autogen.sh
-    - ./configure CFLAGS='-std=c99 -pedantic -Wall -Wextra -Werror' CPPFLAGS='-D_XOPEN_SOURCE=600' --disable-silent-rules || (cat config.log && exit 42)
+    - ./configure CFLAGS='-std=c99 -pedantic -Wall -Wextra -Werror' CPPFLAGS='-D_XOPEN_SOURCE=600' --disable-silent-rules --with-libedit || (cat config.log && exit 42)
     - make -j
     - make -j distcheck
 
@@ -49,8 +49,8 @@ debian-amd64:
   image: debian:bullseye
   script:
     - apt-get update
-    - apt-get install -y --no-install-recommends build-essential libcurl4-openssl-dev pkgconf autotools-dev bison flex make autoconf automake libtool libbsd-dev libatf-dev kyua
+    - apt-get install -y --no-install-recommends build-essential libcurl4-openssl-dev pkgconf autotools-dev bison flex make autoconf automake libtool libbsd-dev libatf-dev kyua libreadline-dev
     - ./autogen.sh
-    - ./configure CFLAGS='-std=c99 -pedantic -Wall -Wextra -Werror -Wno-misleading-indentation' CPPFLAGS='-D_XOPEN_SOURCE=600' --disable-silent-rules || (cat config.log && exit 42)
+    - ./configure CFLAGS='-std=c99 -pedantic -Wall -Wextra -Werror -Wno-misleading-indentation' CPPFLAGS='-D_XOPEN_SOURCE=600' --disable-silent-rules --with-readline || (cat config.log && exit 42)
     - make -j
     - make -j distcheck

Changelog.md

@@ -2,6 +2,56 @@
 
 This changelog does not follow semantic versioning.
 
+## 2.3.0 (2024-Mar-25)
+
+### Added
+
+- It is now possible to build gcli against libgcli as a DLL on cygwin.
+  Submitted by: Daisuke Fujimura
+
+- The pulls subcommand now allows searching for pull requests with
+  a given search term. The search terms can be appended to the
+  regular pull subcommand for listing PRs:
+
+  ```console
+  $ gcli pulls -L bug segmentation fault
+  ```
+
+  The above will search for pull requests containing »segmentation
+  fault« and the label »bug«.
+
+- An interactive mode for creating both PRs and issues has been added.
+  You can now interactively create pull requests and issues by omitting their title:
+
+  ```console
+  $ gcli issues create
+  Owner [herrhotzenplotz]:
+  Repository [gcli]:
+  Title: foo
+  The following issue will be created:
+
+  TITLE   : foo
+  OWNER   : herrhotzenplotz
+  REPO    : gcli
+  MESSAGE :
+  No message
+
+  Do you want to continue? [yN]
+  ```
+
+### Fixed
+
+- gcli was incorrectly using an environment variable *XDG_CONFIG_DIR*.
+  This variable has now been fixed to be *XDG_CONFIG_HOME*.
+  Submitted by: Jakub Wilk
+
+- Fixed a segmentation fault when listing forks
+
+- Fixed error when submitting a comment on Gitlab issues
+
+- The build on Haiku has been fixed. GCLI can now be compiled and
+  used on this platform.
+
 ## 2.2.0 (2024-Feb-05)
 
 ### Added

Makefile.am

@@ -13,20 +13,21 @@ AM_CFLAGS = -Wno-gnu-zero-variadic-macro-arguments
 noinst_PROGRAMS = pgen$(EXEEXT)
 pgen_SOURCES = \
 	include/gcli/pgen.h \
+	thirdparty/sn/sn.c \
 	src/pgen/dump_c.c \
 	src/pgen/dump_h.c \
 	src/pgen/dump_plain.c \
 	src/pgen/parser.y \
 	src/pgen/lexer.l
 
 lib_LTLIBRARIES = libgcli.la
-noinst_LTLIBRARIES = libsn.la libpdjson.la
+noinst_LTLIBRARIES = libpdjson.la
 
 # For testing puproses I'll reenable parallel builds. If it breaks again, uncomment.
 # .NOTPARALLEL: pgen$(EXEEXT) $(builddir)/src/pgen/parser.c $(builddir)/src/pgen/parser.h $(builddir)/src/pgen/lexer.c
 src/pgen/lexer.c: src/pgen/parser.h
 
-libgcli_la_DEPENDENCIES = pgen$(EXEEXT) libpdjson.la libsn.la
+libgcli_la_DEPENDENCIES = pgen$(EXEEXT) libpdjson.la
 
 $(BUILT_SOURCES): pgen$(EXEEXT)
 
@@ -40,7 +41,8 @@ SUFFIXES = .t
 bin_PROGRAMS = gcli$(EXEEXT)
 gcli_LDADD = libgcli.la
 
-libgcli_la_LIBADD = libpdjson.la libsn.la
+libgcli_la_LIBADD = libpdjson.la
+libgcli_la_LDFLAGS = -no-undefined
 
 dist_man_MANS = \
 	docs/gcli-api.1 \
@@ -82,13 +84,10 @@ gcli_SOURCES = \
 	include/gcli/cmd/snippets.h src/cmd/snippets.c \
 	include/gcli/cmd/status.h src/cmd/status.c \
 	include/gcli/cmd/table.h src/cmd/table.c \
+	include/gcli/cmd/interactive.h src/cmd/interactive.c \
 	src/cmd/api.c \
 	src/cmd/gcli.c
 
-libsn_la_SOURCES = \
-	thirdparty/sn/sn.c \
-	thirdparty/sn/sn.h
-
 libpdjson_la_SOURCES = \
 	thirdparty/pdjson/pdjson.c \
 	thirdparty/pdjson/pdjson.h
@@ -200,7 +199,8 @@ libgcli_la_SOURCES = \
 	src/bugzilla/bugs.c include/gcli/bugzilla/bugs.h \
 	src/bugzilla/bugs-parser.c include/gcli/bugzilla/bugs-parser.h \
 	src/bugzilla/config.c include/gcli/bugzilla/config.h \
-	$(TEMPLATES)
+	$(TEMPLATES) \
+	thirdparty/sn/sn.c thirdparty/sn/sn.h
 
 libgcli_la_CPPFLAGS = \
 	$(AM_CPPFLAGS) \
@@ -245,57 +245,84 @@ do_test: $(check_PROGRAMS) tests/Kyuafile
 
 tests_json_escape_SOURCES = \
 	tests/json-escape.c
+tests_json_escape_CFLAGS = \
+	$(AM_CFLAGS) \
+	$(LIBATFC_CFLAGS)
 tests_json_escape_LDADD = \
-	libgcli.la libpdjson.la libsn.la \
-	$(LIBATFC_LDFLAGS)
+	libgcli.la libpdjson.la \
+	$(LIBATFC_LIBS)
 
 tests_github_parse_tests_SOURCES = \
 	tests/github-parse-tests.c
+tests_github_parse_tests_CFLAGS = \
+	$(AM_CFLAGS) \
+	$(LIBATFC_CFLAGS)
 tests_github_parse_tests_LDADD = \
-	libgcli.la libpdjson.la libsn.la \
-	$(LIBATFC_LDFLAGS)
+	libgcli.la libpdjson.la \
+	$(LIBATFC_LIBS)
 
 tests_gitlab_parse_tests_SOURCES = \
 	tests/gitlab-parse-tests.c
+tests_gitlab_parse_tests_CFLAGS = \
+	$(AM_CFLAGS) \
+	$(LIBATFC_CFLAGS)
 tests_gitlab_parse_tests_LDADD = \
-	libgcli.la libpdjson.la libsn.la \
-	$(LIBATFC_LDFLAGS)
+	libgcli.la libpdjson.la \
+	$(LIBATFC_LIBS)
 
 tests_gitea_parse_tests_SOURCES = \
 	tests/gitea-parse-tests.c
+tests_gitea_parse_tests_CFLAGS = \
+	$(AM_CFLAGS) \
+	$(LIBATFC_CFLAGS)
 tests_gitea_parse_tests_LDADD = \
-	libgcli.la libpdjson.la libsn.la \
-	$(LIBATFC_LDFLAGS)
+	libgcli.la libpdjson.la \
+	$(LIBATFC_LIBS)
 
 tests_bugzilla_parse_tests_SOURCES = \
 	tests/bugzilla-parse-tests.c
+tests_bugzilla_parse_tests_CFLAGS = \
+	$(AM_CFLAGS) \
+	$(LIBATFC_CFLAGS)
 tests_bugzilla_parse_tests_LDADD = \
-	libgcli.la libpdjson.la libsn.la \
-	$(LIBATFC_LDFLAGS)
+	libgcli.la libpdjson.la \
+	$(LIBATFC_LIBS)
 
 tests_base64_tests_SOURCES = \
 	tests/base64-tests.c
+tests_base64_tests_CFLAGS = \
+	$(AM_CFLAGS) \
+	$(LIBATFC_CFLAGS)
 tests_base64_tests_LDADD = \
-	libgcli.la libpdjson.la libsn.la \
-	$(LIBATFC_LDFLAGS)
+	libgcli.la libpdjson.la \
+	$(LIBATFC_LIBS)
 
 tests_url_encode_SOURCES = \
 	tests/url-encode.c
+tests_url_encode_CFLAGS = \
+	$(AM_CFLAGS) \
+	$(LIBATFC_CFLAGS)
 tests_url_encode_LDADD = \
-	libgcli.la libpdjson.la libsn.la \
-	$(LIBATFC_LDFLAGS)
+	libgcli.la libpdjson.la \
+	$(LIBATFC_LIBS)
 
 tests_pretty_print_test_SOURCES = \
-	tests/pretty_print_test.c
+	tests/pretty_print_test.c \
+	thirdparty/sn/sn.c thirdparty/sn/sn.h
+tests_pretty_print_test_CFLAGS = \
+	$(AM_CFLAGS) \
+	$(LIBATFC_CFLAGS)
 tests_pretty_print_test_LDADD = \
-	libsn.la \
-	$(LIBATFC_LDFLAGS)
+	$(LIBATFC_LIBS)
 
 tests_test_jsongen_SOURCES = \
 	tests/test-jsongen.c
+tests_test_jsongen_CFLAGS = \
+	$(AM_CFLAGS) \
+	$(LIBATFC_CFLAGS)
 tests_test_jsongen_LDADD = \
 	libgcli.la \
-	$(LIBATFC_LDFLAGS)
+	$(LIBATFC_LIBS)
 
 EXTRA_DIST += tests/samples/github_simple_comment.json	\
 	tests/samples/github_simple_fork.json		\

README.md

@@ -33,6 +33,9 @@ consider using the link above.
 There are official packages available:
 
 - [FreeBSD](https://freshports.org/devel/gcli)
+- [Debian Testing](https://packages.debian.org/trixie/gcli)
+- [ArchLinux AUR](https://aur.archlinux.org/packages/gcli)
+- [NixPkgs Unstable](https://search.nixos.org/packages?channel=unstable&show=gcli&from=0&size=50&sort=relevance&type=packages&query=gcli)
 
 ### Dependencies