Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the UX of README command codeblocks #698

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Oct 18, 2023

  • Removes the leading terminal prompt $ from single command codeblocks, so that GitHub's "copy to clipboard" feature can be used to copy the commands directly into the terminal.
  • Switches multi-line "command plus example output" codeblocks from language shell to console to prevent broken syntax highlighting (e.g. the "test" in "To test your buildpack" was being highlighted as a bash script, not console output).

GUS-W-14320799.

@edmorley edmorley added documentation Improvements or additions to documentation skip changelog labels Oct 18, 2023
@edmorley edmorley self-assigned this Oct 18, 2023
* Removes the leading terminal prompt `$` from single command
  codeblocks, so that GitHub's "copy to clipboard" feature can be
  used to copy the commands directly into the terminal.
* Switches multi-line "command plus example output" codeblocks
  from language `shell` to `console` to prevent broken syntax
  highlighting (e.g. the "test" in "To test your buildpack" was being
  highlighted as a bash script, not console output).
@edmorley edmorley force-pushed the edmorley/codeblock-ux branch from 4cf943c to b48cd62 Compare October 18, 2023 11:51
@edmorley edmorley marked this pull request as ready for review October 18, 2023 11:53
@edmorley edmorley requested a review from a team as a code owner October 18, 2023 11:53
@edmorley edmorley merged commit 664ec78 into main Oct 18, 2023
4 checks passed
@edmorley edmorley deleted the edmorley/codeblock-ux branch October 18, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants