Ignore file support when finding buildpacks #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we could rely on knowing that packaged buildpacks would be written to a location within the `target` directory configured in Crate. This was easy to determine through program code and could be supplied to `find_buildpack_dirs` so that packaged buildpacks weren't accidentally included when searching for buildpacks. With the changes introduced in [#583](#583) it is no longer possible to easily determine the output location for packaged buildpacks. This PR adds the [ignore](https://crates.io/crates/ignore) crate to provide directory iteration that respects standard ignore files. This will give the user the ability to configure where we search within a project for buildpacks.
edmorley
reviewed
Sep 14, 2023
* updated error message * using iterator instead of loop for finding buildpack dirs logic * added a quick test to ensure that ignores work * updated changelog entry
* updated error message * using iterator instead of loop for finding buildpack dirs logic * added a quick test to ensure that ignores work * updated changelog entry
Malax
reviewed
Sep 18, 2023
Malax
reviewed
Sep 18, 2023
Malax
approved these changes
Sep 18, 2023
edmorley
approved these changes
Sep 18, 2023
* updated test comments * added PR link to changelog entry
edmorley
approved these changes
Sep 18, 2023
colincasey
added a commit
that referenced
this pull request
Sep 19, 2023
* main: Ignore file support when finding buildpacks (#673) Apply rustfmt to README example (#676) Update example `cargo libcnb package` log output in READMEs (#675) Add CLI usage help output to libcnb-cargo README (#674) Fix lint errors with Rust 1.73 (#672) Include README.md in lib.rs (#667) # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we could rely on knowing that packaged buildpacks would be written to a location within the
targetdirectory configured in Crate. This was easy to determine through program code and could be supplied tofind_buildpack_dirsso that packaged buildpacks weren't accidentally included when searching for buildpacks.With the changes introduced in #583 it is no longer possible to easily determine the output location for packaged buildpacks. This PR adds the ignore crate to provide directory iteration that respects standard ignore files. This will give the user the ability to configure where we search within a project for buildpacks.
Related to #666