Skip to content

Commit

Permalink
Switch tests from heroku/buildpacks:20 to heroku/builder:20 (#693)
Browse files Browse the repository at this point in the history
Since the `heroku/buildpacks:20` image is about to be deprecated,
and has been replaced by the newly added `heroku/builder:20` for
those that need to use a Heroku-20 based builder.

The build and run images used by `heroku/builder:20` are the same as
those used by `heroku/buildpacks:20` - the only differences between the
builders are the included buildpacks (which is somewhat irrelevant for
these integration tests, since the buildpack under test will be injected instead).

See:
heroku/cnb-builder-images#394
https://salesforce.quip.com/0JtbAYiWZYk6

GUS-W-14186015.
  • Loading branch information
edmorley authored Sep 27, 2023
1 parent 56b4f4e commit 1970f47
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions examples/ruby-sample/tests/integration_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ use std::{fs, io};
#[test]
#[ignore = "integration test"]
fn basic() {
let config = BuildConfig::new("heroku/buildpacks:20", "tests/fixtures/simple-ruby-app");
let config = BuildConfig::new("heroku/builder:20", "tests/fixtures/simple-ruby-app");

TestRunner::default().build(&config, |context| {
assert_contains!(context.pack_stdout, "---> Ruby Buildpack");
Expand Down Expand Up @@ -60,7 +60,7 @@ fn basic() {
#[ignore = "integration test"]
fn missing_gemfile_lock() {
TestRunner::default().build(
BuildConfig::new("heroku/buildpacks:20", "tests/fixtures/simple-ruby-app")
BuildConfig::new("heroku/builder:20", "tests/fixtures/simple-ruby-app")
.app_dir_preprocessor(|path| fs::remove_file(path.join("Gemfile.lock")).unwrap())
.expected_pack_result(PackResult::Failure),
|context| {
Expand Down

0 comments on commit 1970f47

Please sign in to comment.