Support source parts directory #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
reviewed
Mar 19, 2024
colincasey
force-pushed
the
support_source_parts_dir
branch
2 times, most recently
from
2d5f283 to
d2897fc
Compare
colincasey
changed the base branch from
fix_empty_aptfile
to
fix_for_aptfile_with_no_packages
colincasey
force-pushed
the
support_source_parts_dir
branch
from
d2897fc to
5468a46
Compare
Merged
colincasey
force-pushed
the
support_source_parts_dir
branch
from
5468a46 to
9e1a71e
Compare
colincasey
force-pushed
the
fix_for_aptfile_with_no_packages
branch
from
e8b841d to
e5a642c
Compare
colincasey
force-pushed
the
support_source_parts_dir
branch
from
9e1a71e to
3b066dc
Compare
dzuelke
requested changes
Mar 28, 2024
There was a problem hiding this comment.
You can use jammy builds for noble in the tests:
root@3ecdc55e4611:~# wget -q https://github.com/wkhtmltopdf/packaging/releases/download/0.12.6.1-2/wkhtmltox_0.12.6.1-2.jammy_amd64.deb
root@3ecdc55e4611:~# dpkg -x wkhtmltox_0.12.6.1-2.jammy_amd64.deb .
root@3ecdc55e4611:~# find usr -type f \( -executable -o -name "*.a" \) -exec ldd -r "{}" \; | grep -e "not found" -e "undefined symbol" || echo "all good"
all good
colincasey
force-pushed
the
fix_for_aptfile_with_no_packages
branch
from
e5a642c to
2b1891a
Compare
colincasey
force-pushed
the
support_source_parts_dir
branch
from
3b066dc to
55ef1b8
Compare
colincasey
force-pushed
the
support_source_parts_dir
branch
from
55ef1b8 to
aa5c018
Compare
|
@dzuelke I've added your suggestion to use the jammy package for noble in custom package url tests. |
dzuelke
approved these changes
Mar 28, 2024
Merged
Frzk
pushed a commit
to Scalingo/apt-buildpack
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for copying the source list configuration files from
/etc/apt/sources.list.dinto the sources used for theapt-getcommand line invocations and makes sure these are included in theAPT_OPTIONS.GUS-W-14674577
Fixes #114