Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Steps for Windows #50

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

RafaelCopat
Copy link

Please consider this pull request with details from the solved issue to run in Windows. I faced the problems before checking the issues and lost some time. Only a small change in readme.

@edmorley edmorley requested a review from joshwlewis January 16, 2024 14:25
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for opening a PR.

This repository goes alongside the "Getting Started on Heroku with Go" guide here:
https://devcenter.heroku.com/articles/getting-started-with-go

In that guide, the "running locally" section says to go install -v . prior to running heroku local, which I believe then makes the current Procfile work as is.

As such, I think the real fix here is to update the comment being run to build/install the project, rather than to suggest the user change what is in the Procfile. As-is, I think the current advice in the README here is not only broken on Windows, but on Linux too, since it says to save the contents of the go build into a bin directory, which differs from the path in Procfile.

However, rather than fix the instructions in README, I think it might be best to remove them entirely, and instead link out to the full guide on Dev Center, since it saves having to keep both in sync. Linking out to Dev Center is also what the READMEs for many of the other language's getting started guides do already, eg:

@edmorley edmorley removed the request for review from joshwlewis February 3, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants