Add logging statements to the shim #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneems
force-pushed
the
schneems/tell-me-what-ur-doing-please
branch
from
6043ff3 to
4572c44
Compare
Right now then code in the shim fails it looks like the error is inside of the buildpack itself. For example this error: ``` [builder] -----> Detecting rails configuration [builder] exit status 127 [builder] ERROR: failed to build: exit status 3 ERROR: failed to build: executing lifecycle. This may be the result of using an untrusted builder: failed with status code: 51 ``` Appears to indicate that the problem happened in `bin/compile` when in fact that was successful and the real problem didn't happen until `bin/release`. By logging our intentions to the output it makes it clearer to understand where failures are happening if/when they do happen.
edmorley
force-pushed
the
schneems/tell-me-what-ur-doing-please
branch
from
4572c44 to
3e1b6a9
Compare
* Prefix all output with `CNB Shim:` since otherwise it's not clear whether its the buildpack or the shim's output. * Move the output for optional steps inside the step's conditional * Adjust some of the step wordings
|
I rebased this on
For the changes, see: I triggered a builder CI run using the Review App for this PR - tests passed: And the new output can be seen in eg: |
edmorley
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now then code in the shim fails it looks like the error is inside of the buildpack itself. For example this error:
Appears to indicate that the problem happened in
bin/compilewhen in fact that was successful and the real problem didn't happen untilbin/release. By logging our intentions to the output it makes it clearer to understand where failures are happening if/when they do happen.