Add heroku/deb-packages to 22/24 builders
#591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Thank you for adding this to the builder - I think having it included is a great win for UX.
I notice the buildpack wasn't added to heroku/builder:20 - I think this makes sense, but is perhaps worth calling out in the PR description to avoid user confusion.
Medium/longer term I'd love to have upstream support for system buildpacks be implemented (the RFC for it was accepted some time ago, but it hasn't been implemented yet: buildpacks/rfcs#209) - since both heroku/procfile and now heroku/deb-packages could make use of it :-)
joshwlewis
approved these changes
Oct 16, 2024
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Registers the heroku/deb-packages buildpack in the following builders, prepending it to each buildpack group as an optional buildpack that runs at the start for:
heroku/builder:24heroku/builder:22Note
This will not be added to
heroku/builder:20as that builder is deprecated.GUS-W-17066441.