Update lifecycle from v0.17.2 to v0.18.1 #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![heroku-linguist[bot]](https://avatars.githubusercontent.com/u/23211?s=60&v=4){kind=small}
|
CI is failing because:
In addition to the cases seen in CI, there is also at least one Functions customer using this Buildpack API 0.2 (!!) buildpack: |
heroku-linguist
bot
changed the title
heroku-linguist
bot
force-pushed
the
update-lifecycle
branch
from
992e419 to
83a1f17
Compare
heroku-linguist
bot
force-pushed
the
update-lifecycle
branch
from
83a1f17 to
4fea415
Compare
heroku-linguist
bot
force-pushed
the
update-lifecycle
branch
from
4fea415 to
edf2fab
Compare
Since these builder images contain buildpacks that are using Buildpack API versions no longer supported in lifecycle 0.18.0+: https://github.com/buildpacks/lifecycle/releases/tag/v0.18.0 https://github.com/buildpacks/lifecycle#supported-apis
I've downgraded the lifecycle version in the affected builder images to their original lifecycle version. For now, we'll only use the new lifecycle version in This is still a breaking change for anyone using
|
edmorley
approved these changes
Nov 14, 2023
This was referenced Nov 15, 2023
edmorley
added a commit
to heroku/buildpacks-nodejs
that referenced
this pull request
Nov 15, 2023
Since Buildpack API 0.6 has been deprecated for some time, and is no longer supported by newer versions of `lifecycle`, which is causing CI to fail since the integration tests in this repo use `heroku/builder:22`, which has just had its lifecycle version upgraded: heroku/cnb-builder-images#431 These CI failures are not reflective of production (which is working fine), since Functions in production are actually run via the functions builder image (and not `heroku/builder:22`), which was intentionally left on the old lifecycle version. However, this functions builder image is not available on Docker Hub, so can't be used by the integration tests in this repo. Improving parity of the integration tests here might be worth considering longer term, however, upgrading the Buildpack API version was a simpler (and arguably correct thing to do regardless) step for now. There are no breaking changes that affect this buildpack in the new API version, so no buildpack changes were required: https://github.com/buildpacks/spec/releases/tag/buildpack%2Fv0.7 Fixes #720. GUS-W-14493124.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes:
https://github.com/buildpacks/lifecycle/releases/tag/v0.18.0
https://github.com/buildpacks/lifecycle/releases/tag/v0.18.1
Full changelog:
buildpacks/lifecycle@v0.17.2...v0.18.1