Stop publishing non-functions images to the internal registry #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `heroku/buildpacks:20` and `heroku/builder:22` builders are now only published to Docker Hub, rather than also being published to the internal registry (under the `heroku-20:builder` and `heroku-22:builder` tags respectively). Kodon has not defaulted to these non-functions images from the internal registry for some time, and as of heroku/kodon#410 these images (and the internal registry) are no longer on the builder allow list, so it's not possible to manually select them using `project.toml`. This change does not affect the functions-only image, which continues to be published to (and consumed by Kodon from) the internal registry.
Malax
approved these changes
Oct 27, 2023
|
I've also removed the old images, so people don't accidentally start using them in the future for new use-cases not realising they are no longer updated: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
heroku/buildpacks:20andheroku/builder:22builders are now only published to Docker Hub, rather than also being published to the internal registry (where they were tagged asheroku-20:builderandheroku-22:builderrespectively).Kodon has not defaulted to these non-functions images from the internal registry for some time, and as of heroku/kodon#410 these images (and the internal registry) are no longer on the builder allow list, so it's not possible to manually select them using
project.toml.This change does not affect the functions-only image, which continues to be published to (and consumed by the functions-specific Kodon instance from) the internal registry.
GUS-W-14378185.