Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip registry login if not publishing to that specific registry #391

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

edmorley
Copy link
Member

@edmorley edmorley commented Sep 25, 2023

When new builder images are published, they can be published to two different registries:

  1. The public Docker repo on Docker Hub
  2. A private internal registry

Previously we'd always log into both registries, even if that particular job was only publishing to one of the two registries.

Several of our images are already only published to one of the two registries, and soon virtually all of them will be (as part of upcoming PRs to add new image variants) - meaning it makes even more sense to skip login if it's not needed.

GUS-W-14179420.

When new builder images are published on main, they can be
published to two different registries:
1. The public Docker repo on Docker Hub
2. A private internal registry

Previously we'd always log into both registries, even if that particular
job was only publishing to one of the two registries.

Several of our images are already only published to one of the two
registries, and soon virtually all of them will be (as part of upcoming
PRs to add new image variants) - meaning it makes even more sense
to skip login if it's not needed.
@edmorley edmorley self-assigned this Sep 25, 2023
@edmorley edmorley marked this pull request as ready for review September 25, 2023 17:01
@edmorley edmorley requested a review from a team as a code owner September 25, 2023 17:01
@edmorley edmorley merged commit b83a360 into main Sep 25, 2023
35 checks passed
@edmorley edmorley deleted the edmorley/skip-registry-login branch September 25, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants