Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update heroku/buildpacks-jvm to v3.1.0 #381

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Update heroku/buildpacks-jvm to v3.1.0 #381

merged 2 commits into from
Sep 19, 2023

Conversation

heroku-linguist[bot]
Copy link
Contributor

heroku/gradle

Added

  • Initial release

heroku/java

  • Updated heroku/procfile to 2.0.1. (#568)
  • Updated heroku/gradle to 3.1.0.
  • Updated heroku/jvm to 3.1.0.
  • Updated heroku/maven to 3.1.0.

heroku/java-function

  • Updated heroku/jvm-function-invoker to 3.1.0.
  • Updated heroku/jvm to 3.1.0.
  • Updated heroku/maven to 3.1.0.

heroku/jvm

  • Default version for OpenJDK 11 is now 11.0.20.1. (#582)
  • Default version for OpenJDK 17 is now 17.0.8.1. (#582)

heroku/jvm-function-invoker

  • No changes.

heroku/maven

  • No changes.

heroku/sbt

  • No changes.

heroku/scala

  • Updated heroku/procfile to 2.0.1. (#568)
  • Updated heroku/jvm to 3.1.0.
  • Updated heroku/sbt to 3.1.0.

@heroku-linguist
Update heroku/buildpacks-jvm to v3.1.0
d0ec832 
## heroku/gradle

### Added

* Initial release

## heroku/java

- Updated `heroku/procfile` to `2.0.1`. ([#568](heroku/buildpacks-jvm#568))
- Updated `heroku/gradle` to `3.1.0`.
- Updated `heroku/jvm` to `3.1.0`.
- Updated `heroku/maven` to `3.1.0`.

## heroku/java-function

- Updated `heroku/jvm-function-invoker` to `3.1.0`.
- Updated `heroku/jvm` to `3.1.0`.
- Updated `heroku/maven` to `3.1.0`.

## heroku/jvm

* Default version for **OpenJDK 11** is now `11.0.20.1`. ([#582](heroku/buildpacks-jvm#582))
* Default version for **OpenJDK 17** is now `17.0.8.1`. ([#582](heroku/buildpacks-jvm#582))

## heroku/jvm-function-invoker

- No changes.

## heroku/maven

- No changes.

## heroku/sbt

- No changes.

## heroku/scala

- Updated `heroku/procfile` to `2.0.1`. ([#568](heroku/buildpacks-jvm#568))
- Updated `heroku/jvm` to `3.1.0`.
- Updated `heroku/sbt` to `3.1.0`.
@heroku-linguist heroku-linguist bot requested a review from a team as a code owner September 18, 2023 16:45
@heroku-linguist heroku-linguist bot enabled auto-merge (squash) September 18, 2023 16:45
Malax
Malax requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@Malax Malax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gradle is missing here because it's a new buildpack - I'll fix this PR up manually.

@edmorley
Copy link
Member

Gradle is missing here because it's a new buildpack - I'll fix this PR up manually.

I presume this is because the CNB automation doesn't handle this case automatically? Could you also file an issue for adding support? :-)

@Malax
Copy link
Member

Malax commented Sep 19, 2023

Gradle is missing here because it's a new buildpack - I'll fix this PR up manually.

I presume this is because the CNB automation doesn't handle this case automatically? Could you also file an issue for adding support? :-)

My comment earlier wasn't entirely correct - it is missing, but that's actually what we want. We also don't have Maven or sbt CNBs directly in the builder so that's fine. I do need to disable a handful of workarounds me made when Gradle didn't have a CNB.

@edmorley
Copy link
Member

Ah I was thinking from the changelog too, but I see the "initial release" for heroku/gradle in in the PR description already :-)

@edmorley edmorley linked an issue Sep 19, 2023 that may be closed by this pull request
builder:22 image doesn't feature any Gradle functionality #324
Closed
@edmorley
Copy link
Member

Ah the languages list here can be updated too:
https://github.com/heroku/builder/blob/21775d4bbd3b1c80472cfa894c1821b72d402228/README.md?plain=1#L17

@Malax
Copy link
Member

Malax commented Sep 19, 2023 •
edited
Loading

Ah the languages list here can be updated too:

Let's do that separately, Scala is also missing. I'll open a PR right after this one. (#383)

@heroku-linguist heroku-linguist bot merged commit 270dd16 into main Sep 19, 2023
@heroku-linguist heroku-linguist bot deleted the update/heroku/buildpacks-jvm branch September 19, 2023 08:33
@edmorley edmorley mentioned this pull request Sep 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Malax Malax Malax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

builder:22 image doesn't feature any Gradle functionality
2 participants
@edmorley @Malax