Skip to content

Commit

Permalink
Stop testing against the TypeScript getting started guide (#421)
Browse files Browse the repository at this point in the history
Since:
- This guide isn't used by any Dev Center documentation:
  https://devcenter.heroku.com/search?q=typescript
- It's outdated (no updates for two years).
- TypeScript apps use the same `heroku/nodejs` CNB as
  JavaScript apps, and `heroku/nodejs` is already tested via the
  main Node.js getting started guide.
- The CI for this repo doesn't test multiple guides for any of the
  other supported languages.
- Removing it unblocks #417 (since the TypeScript guide is missing
  an NPM lockfile).
  • Loading branch information
edmorley authored Oct 25, 2023
1 parent 0824b29 commit e320b24
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/build-test-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
fail-fast: false
matrix:
builder: ["buildpacks-20", "builder-classic-22", "builder-20", "builder-22"]
language: ["go", "gradle", "java", "node-js", "php", "python", "ruby", "scala", "typescript"]
language: ["go", "gradle", "java", "node-js", "php", "python", "ruby", "scala"]
include:
- builder: builder-classic-22
language: clojure
Expand Down

0 comments on commit e320b24

Please sign in to comment.