Skip to content

Commit

Permalink
Switch tests from heroku/buildpacks:20 to heroku/builder:20 (#38)
Browse files Browse the repository at this point in the history
Since the `heroku/buildpacks:20` image is about to be deprecated,
and has been replaced by the newly added `heroku/builder:20` for
those that need to use a Heroku-20 based builder.

The build and run images used by `heroku/builder:20` are the same as
those used by `heroku/buildpacks:20` - the only differences between the
builders are the included buildpacks (which is somewhat irrelevant for
these integration tests, since the buildpack under test will be injected instead).

The smoke tests in the `heroku/builder` GitHub repo are still testing
against all image variants (until such time as we make the legacy images
error with an EOL message), so we still have test coverage against them.

See:
heroku/cnb-builder-images#394
https://salesforce.quip.com/0JtbAYiWZYk6

GUS-W-14186015.
  • Loading branch information
edmorley authored Sep 27, 2023
1 parent fd7b2a4 commit 862570f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
strategy:
fail-fast: false
matrix:
builder: ["builder:22", "buildpacks:20"]
builder: ["builder:22", "builder:20"]
env:
INTEGRATION_TEST_CNB_BUILDER: heroku/${{ matrix.builder }}
steps:
Expand Down

0 comments on commit 862570f

Please sign in to comment.