Skip to content

Commit

Permalink
Update buildpack metadata in buildpack.toml
Browse files Browse the repository at this point in the history
Adjusts the buildpack `name`, `description` and `keywords` in the
`buildpack.toml` of all buildpacks to match the style discussed in:
heroku/cnb-builder-images#408

These fields are used by the CNB registry and can also be seen in the
output of `pack builder inspect`. They are not used by `pack build` or
Kodon. In addition to standardising the metadata, one of the objectives
here is to ensure users don't accidentally use component buildpacks when
they really wanted the composite buildpack.

The `keywords` field has intentionally been omitted from the functions
buildpacks since they are EOL and so don't want to be made more
discoverable. (The CNB registry doesn't currently ingest/display the
keywords currently, but may in the future.)

Lastly, I've cleaned up the `[metadata]` table/subtables to match the
concise style used by the Procfile and Python CNBs.

GUS-W-14121598.
  • Loading branch information
edmorley committed Oct 23, 2023
1 parent 19d30fc commit 8d3dc97
Show file tree
Hide file tree
Showing 20 changed files with 73 additions and 47 deletions.
8 changes: 7 additions & 1 deletion buildpacks/nodejs-corepack/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- Add support for using corepack to install npm ([#685](https://github.com/heroku/buildpacks-nodejs/pull/685))
### Added

- Added support for using corepack to install npm. ([#685](https://github.com/heroku/buildpacks-nodejs/pull/685))

### Changed

- Updated buildpack description and keywords. ([#692](https://github.com/heroku/buildpacks-nodejs/pull/692))

## [1.1.7] - 2023-10-17

Expand Down
7 changes: 3 additions & 4 deletions buildpacks/nodejs-corepack/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ id = "heroku/nodejs-corepack"
version = "1.1.7"
name = "Heroku Node.js Corepack"
homepage = "https://github.com/heroku/buildpacks-nodejs"
keywords = ["corepack", "node", "node.js", "nodejs", "javascript", "js"]
description = "Heroku's Node.js Corepack buildpack. A component of the 'heroku/nodejs' buildpack."
keywords = ["corepack", "heroku"]

[[buildpack.licenses]]
type = "MIT"
Expand All @@ -19,7 +20,5 @@ id = "heroku-22"
[[stacks]]
id = "io.buildpacks.stacks.bionic"

[metadata]
[metadata.release]
[metadata.release.image]
repository = "docker.io/heroku/buildpack-nodejs-corepack"
image = { repository = "docker.io/heroku/buildpack-nodejs-corepack" }
7 changes: 7 additions & 0 deletions buildpacks/nodejs-engine/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- Added Node.js version 21.0.0.

### Changed

- Updated buildpack description and keywords. ([#692](https://github.com/heroku/buildpacks-nodejs/pull/692))

## [1.1.7] - 2023-10-17

- Added Node.js version 20.8.1.
Expand Down
7 changes: 3 additions & 4 deletions buildpacks/nodejs-engine/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ id = "heroku/nodejs-engine"
version = "1.1.7"
name = "Heroku Node.js Engine"
homepage = "https://github.com/heroku/buildpacks-nodejs"
keywords = ["node", "node.js", "nodejs", "javascript", "js"]
description = "Heroku's Node.js engine buildpack. A component of the 'heroku/nodejs' buildpack."
keywords = ["node.js", "nodejs", "heroku"]

[[buildpack.licenses]]
type = "MIT"
Expand All @@ -19,7 +20,5 @@ id = "heroku-22"
[[stacks]]
id = "io.buildpacks.stacks.bionic"

[metadata]
[metadata.release]
[metadata.release.image]
repository = "docker.io/heroku/buildpack-nodejs-engine"
image = { repository = "docker.io/heroku/buildpack-nodejs-engine" }
4 changes: 4 additions & 0 deletions buildpacks/nodejs-function-invoker/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Updated buildpack display name, description and keywords. ([#692](https://github.com/heroku/buildpacks-nodejs/pull/692))

## [1.1.7] - 2023-10-17

- No changes.
Expand Down
8 changes: 3 additions & 5 deletions buildpacks/nodejs-function-invoker/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,19 @@ api = "0.9"
[buildpack]
id = "heroku/nodejs-function-invoker"
version = "1.1.7"
name = "Heroku Node.js Function Invoker"
name = "Salesforce Node.js Function Invoker"
homepage = "https://github.com/heroku/buildpacks-nodejs"
keywords = ["nodejs", "node", "node.js", "javascript", "js", "function"]
description = "Salesforce's Node.js function invoker buildpack. A component of the 'heroku/nodejs-function' buildpack."

[[buildpack.licenses]]
type = "MIT"

[[stacks]]
id = "heroku-22"

[metadata]
[metadata.runtime]
package_name = "@heroku/sf-fx-runtime-nodejs"
package_version = "0.14.1"

[metadata.release]
[metadata.release.image]
repository = "docker.io/heroku/buildpack-nodejs-function-invoker"
image = { repository = "docker.io/heroku/buildpack-nodejs-function-invoker" }
3 changes: 2 additions & 1 deletion buildpacks/nodejs-npm-engine/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- Added npm version 10.2.1.
### Added

- Initial release
9 changes: 4 additions & 5 deletions buildpacks/nodejs-npm-engine/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@ api = "0.9"
[buildpack]
id = "heroku/nodejs-npm-engine"
version = "1.1.7"
name = "Heroku Node.js npm Engine Buildpack"
name = "Heroku Node.js npm Engine"
homepage = "https://github.com/heroku/buildpacks-nodejs"
keywords = ["node", "node.js", "nodejs", "javascript", "js", "npm", "engine"]
description = "Heroku's Node.js npm engine buildpack. A component of the 'heroku/nodejs' buildpack."
keywords = ["npm", "heroku"]

[[buildpack.licenses]]
type = "MIT"
Expand All @@ -22,7 +23,5 @@ id = "heroku-22"
[[stacks]]
id = "io.buildpacks.stacks.bionic"

[metadata]
[metadata.release]
[metadata.release.docker]
repository = "docker.io/heroku/buildpack-nodejs-npm-engine"
image = { repository = "docker.io/heroku/buildpack-nodejs-npm-engine" }
1 change: 0 additions & 1 deletion buildpacks/nodejs-npm-install/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,3 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added

- Initial release

9 changes: 4 additions & 5 deletions buildpacks/nodejs-npm-install/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,16 @@ api = "0.9"
[buildpack]
id = "heroku/nodejs-npm-install"
version = "1.1.7"
name = "Heroku Node.js npm Install Buildpack"
name = "Heroku Node.js npm Install"
homepage = "https://github.com/heroku/buildpacks-nodejs"
keywords = ["node", "node.js", "nodejs", "javascript", "js", "npm", "install"]
description = "Heroku's Node.js npm install buildpack. A component of the 'heroku/nodejs' buildpack."
keywords = ["npm", "heroku"]

[[buildpack.licenses]]
type = "MIT"

[[stacks]]
id = "*"

[metadata]
[metadata.release]
[metadata.release.image]
repository = "docker.io/heroku/buildpack-nodejs-npm-install"
image = { repository = "docker.io/heroku/buildpack-nodejs-npm-install" }
4 changes: 4 additions & 0 deletions buildpacks/nodejs-pnpm-install/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Updated buildpack description and keywords. ([#692](https://github.com/heroku/buildpacks-nodejs/pull/692))

## [1.1.7] - 2023-10-17

- No changes.
Expand Down
7 changes: 3 additions & 4 deletions buildpacks/nodejs-pnpm-install/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ id = "heroku/nodejs-pnpm-install"
version = "1.1.7"
name = "Heroku Node.js pnpm install"
homepage = "https://github.com/heroku/buildpacks-nodejs"
keywords = ["node", "node.js", "nodejs", "javascript", "js", "pnpm"]
description = "Heroku's Node.js pnpm install. A component of the 'heroku/nodejs' buildpack."
keywords = ["pnpm", "heroku"]

[[buildpack.licenses]]
type = "MIT"
Expand All @@ -22,7 +23,5 @@ id = "heroku-22"
[[stacks]]
id = "io.buildpacks.stacks.bionic"

[metadata]
[metadata.release]
[metadata.release.image]
repository = "docker.io/heroku/buildpack-nodejs-pnpm-install"
image = { repository = "docker.io/heroku/buildpack-nodejs-pnpm-install" }
4 changes: 4 additions & 0 deletions buildpacks/nodejs-yarn/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Updated buildpack description and keywords. ([#692](https://github.com/heroku/buildpacks-nodejs/pull/692))

## [1.1.7] - 2023-10-17

- Added Yarn version 4.0.0-rc.53.
Expand Down
7 changes: 3 additions & 4 deletions buildpacks/nodejs-yarn/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ id = "heroku/nodejs-yarn"
version = "1.1.7"
name = "Heroku Node.js Yarn"
homepage = "https://github.com/heroku/buildpacks-nodejs"
keywords = ["node", "node.js", "nodejs", "javascript", "js", "yarn", "yarnpkg"]
description = "Heroku's Node.js Yarn buildpack. A component of the 'heroku/nodejs' buildpack."
keywords = ["yarn", "heroku"]

[[buildpack.licenses]]
type = "MIT"
Expand All @@ -22,7 +23,5 @@ id = "heroku-22"
[[stacks]]
id = "io.buildpacks.stacks.bionic"

[metadata]
[metadata.release]
[metadata.release.image]
repository = "docker.io/heroku/buildpack-nodejs-yarn"
image = { repository = "docker.io/heroku/buildpack-nodejs-yarn" }
4 changes: 4 additions & 0 deletions buildpacks/npm/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Updated buildpack display name, description and keywords. ([#692](https://github.com/heroku/buildpacks-nodejs/pull/692))

## [1.1.7] - 2023-10-17

- No changes.
Expand Down
8 changes: 3 additions & 5 deletions buildpacks/npm/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ api = "0.6"
[buildpack]
id = "heroku/nodejs-npm"
version = "1.1.7"
name = "NPM Buildpack"
name = "Heroku Node.js npm (DEPRECATED)"
homepage = "https://github.com/heroku/buildpacks-nodejs"
keywords = ["nodejs", "node", "npm"]
description = "[DEPRECATED] Heroku's Node.js npm buildpack. Replaced by the 'heroku/nodejs-npm-engine' and 'heroku/nodejs-npm-install' buildpacks."

[[buildpack.licenses]]
type = "MIT"
Expand All @@ -22,7 +22,5 @@ id = "heroku-22"
[[stacks]]
id = "io.buildpacks.stacks.bionic"

[metadata]
[metadata.release]
[metadata.release.image]
repository = "docker.io/heroku/buildpack-nodejs-npm"
image = { repository = "docker.io/heroku/buildpack-nodejs-npm" }
4 changes: 4 additions & 0 deletions meta-buildpacks/nodejs-function/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Updated buildpack display name and description. ([#692](https://github.com/heroku/buildpacks-nodejs/pull/692))

## [1.1.7] - 2023-10-17

### Changed
Expand Down
7 changes: 3 additions & 4 deletions meta-buildpacks/nodejs-function/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ api = "0.9"
[buildpack]
id = "heroku/nodejs-function"
version = "1.1.7"
name = "Node.js Function"
name = "Salesforce Node.js Function"
homepage = "https://github.com/heroku/buildpacks-nodejs"
description = "Salesforce's buildpack for Node.js Functions."

[[buildpack.licenses]]
type = "MIT"
Expand All @@ -23,7 +24,5 @@ version = "1.1.7"
id = "heroku/nodejs-function-invoker"
version = "1.1.7"

[metadata]
[metadata.release]
[metadata.release.image]
repository = "docker.io/heroku/buildpack-nodejs-function"
image = { repository = "docker.io/heroku/buildpack-nodejs-function" }
4 changes: 4 additions & 0 deletions meta-buildpacks/nodejs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Updated buildpack display name, description and keywords. ([#692](https://github.com/heroku/buildpacks-nodejs/pull/692))

## [1.1.7] - 2023-10-17

### Changed
Expand Down
8 changes: 4 additions & 4 deletions meta-buildpacks/nodejs/buildpack.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@ api = "0.9"
[buildpack]
id = "heroku/nodejs"
version = "1.1.7"
name = "Node.js"
name = "Heroku Node.js"
homepage = "https://github.com/heroku/buildpacks-nodejs"
description = "Heroku's buildpack for Node.js applications."
keywords = ["node.js", "nodejs", "javascript", "npm", "yarn", "pnpm", "heroku"]

[[buildpack.licenses]]
type = "MIT"
Expand Down Expand Up @@ -73,7 +75,5 @@ id = "heroku/procfile"
version = "2.0.1"
optional = true

[metadata]
[metadata.release]
[metadata.release.image]
repository = "docker.io/heroku/buildpack-nodejs"
image = { repository = "docker.io/heroku/buildpack-nodejs" }

0 comments on commit 8d3dc97

Please sign in to comment.