-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PACKAGE_ENV_VARS for package environment variable mapping #84
Open
tiff-ritz
wants to merge
6
commits into
heroku:main
Choose a base branch
from
tiff-ritz:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiff-ritz
changed the title
Added a FromStr implementation to debian::MultiarchName
Configurable Env Vars from project.toml
Dec 27, 2024
tiff-ritz
force-pushed
the
main
branch
2 times, most recently
from
December 30, 2024 16:40
b95a6ce
to
2e9918a
Compare
tiff-ritz
changed the title
Configurable Env Vars from project.toml
Configurable Env Vars and Post Installation Commands from project.toml
Dec 31, 2024
# This is the 1st commit message: added code to set GIT_EXEC_PATH while installing packages. Added a FromStr implementation to debian::MultiarchName in order to implement a unit test document adding GIT_EXEC_PATH in the readme table of environment variables # This is the commit message #2: add setting of GS_LIB
Added a FromStr implementation to debian::MultiarchName Implment functionality to load the environment variables associate with packages from the project.toml file use PACKAGE_ENV_VARS constand to map default env vars to be defined if the package is in the project.toml file - these can be overwritten by the values in the project.toml file define the package_env_vars before the env vars in the project.toml file update README to reflect the PACKAGE_ENV_VARS testing the buildpack, added a variable for skipped_packages. Will incorporate that into install_packages move the env logic into configure_layer_environment. Iterate through the skipped_packages to make sure all the env vars are set and the post install command are run flushed out a test in order to accomindate the new parameters passed to configure_layer_environment finished the test for skipped packages update the unit test to use a fixture to create the env correctly use a fixture for the test project.toml file; update the README
remove configurable env and post commands,
tiff-ritz
changed the title
Configurable Env Vars and Post Installation Commands from project.toml
PACKAGE_ENV_VARS for package environment variable mapping
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The buildpack includes a set of default environment variables for each package, known as
PACKAGE_ENV_VARS
. These default environment variables are applied during the build process. However, you can override these default values by specifying environment variables in the project.toml file.If a package is listed in the project.toml file with environment variables under the env key, those variables will take precedence over the default
PACKAGE_ENV_VARS
.Added unit tests to:
Integration Tests added: