Upgrade pgx to v5 and use trimmed sql-migrate (Rebase:4bf4c19) #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesposito
requested changes
Aug 2, 2023
redbaron
reviewed
Aug 5, 2023
|
|
||
| // Check migration status and fail fast if the schema has diverged. | ||
| migrate.StartupCheck(startupLogger, db) | ||
| conn, err := db.Conn(context.Background()) |
There was a problem hiding this comment.
looks like this leaks connection. needs conn.Close() on success and errors paths
redbaron
reviewed
Aug 5, 2023
server/console_channel.go
Outdated
| @@ -55,7 +55,7 @@ func (s *ConsoleServer) DeleteChannelMessages(ctx context.Context, in *console.D | |||
|
|
|||
| var res sql.Result | |||
| var err error | |||
| if res, err = s.db.ExecContext(ctx, query, &pgtype.Timestamptz{Time: deleteBefore, Status: pgtype.Present}); err != nil { | |||
| if res, err = s.db.ExecContext(ctx, query, &pgtype.Timestamptz{Time: deleteBefore, Valid: true}); err != nil { | |||
There was a problem hiding this comment.
AFAIK time.Time is natively supported for both args and scanning into
redbaron
reviewed
Aug 5, 2023
server/core_account.go
Outdated
| @@ -72,7 +73,7 @@ func GetAccount(ctx context.Context, logger *zap.Logger, db *sql.DB, statusRegis | |||
| var updateTime pgtype.Timestamptz | |||
| var verifyTime pgtype.Timestamptz | |||
| var disableTime pgtype.Timestamptz | |||
| var deviceIDs pgtype.VarcharArray | |||
| var deviceIDs pgtype.Array[string] | |||
There was a problem hiding this comment.
there is FlatArray[T] which is just a newtype for []T and doesn't support multidimentional arrays because of that, but otherwise should work just as well here
redbaron
reviewed
Aug 5, 2023
sesposito
force-pushed
the
ff-spe-upgrade-pgx-v5-migrate
branch
from
dd908aa
to
1fae047
Compare
sesposito
force-pushed
the
ff-spe-upgrade-pgx-v5-migrate
branch
2 times, most recently
from
14b9c61
to
498256f
Compare
Use trimmed sql-migrate Config and db creation refactor.
Bug fixes. Improve performance of notification persist.
sesposito
force-pushed
the
ff-spe-upgrade-pgx-v5-migrate
branch
from
498256f
to
76bda02
Compare
|
Superseded by: #1218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use trimmed sql-migrate
Config and db creation refactor.
Original PR: #985