Prefix storage index values with 'value.'

heroiclabs · Aug 22, 2023 · 259f432 · 259f432
1 parent 2d76ca2
commit 259f432
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/server/storage_index.go b/server/storage_index.go
@@ -299,6 +299,7 @@ LIMIT $2`
 		if err != nil {
 			return err
 		}
+		defer rows.Close()
 
 		var rowsRead bool
 		batch := bluge.NewBatch()
@@ -338,6 +339,7 @@ LIMIT $2`
 
 			doc, err := si.mapIndexStorageFields(dbUserID.String(), idx.Collection, dbKey, dbVersion, dbValue, idx.Fields, dbUpdateTime.Time)
 			if err != nil {
+				rows.Close()
 				si.logger.Error("Failed to map storage object values to index", zap.Error(err))
 				return err
 			}
@@ -417,7 +419,7 @@ func (si *LocalStorageIndex) mapIndexStorageFields(userID, collection, key, vers
 	rv.AddField(bluge.NewKeywordField("user_id", userID).StoreValue())
 	rv.AddField(bluge.NewKeywordField("version", version).StoreValue())
 
-	BlugeWalkDocument(mapValue, []string{}, rv)
+	BlugeWalkDocument(mapValue, []string{"value"}, rv)
 
 	return rv, nil
 }

diff --git a/server/storage_index_test.go b/server/storage_index_test.go
@@ -168,7 +168,7 @@ func TestLocalStorageIndex_Write(t *testing.T) {
 			t.Fatal(err.Error())
 		}
 
-		entries, err := storageIdx.List(ctx, indexName1, "+three:3", maxEntries1)
+		entries, err := storageIdx.List(ctx, indexName1, "+value.three:3", maxEntries1)
 		if err != nil {
 			t.Fatal(err.Error())
 		}
@@ -362,7 +362,7 @@ func TestLocalStorageIndex_List(t *testing.T) {
 			t.Fatal(err.Error())
 		}
 
-		entries, err := storageIdx.List(ctx, indexName, "one:1 three:3", 10)
+		entries, err := storageIdx.List(ctx, indexName, "value.one:1 value.three:3", 10)
 		if err != nil {
 			t.Fatal(err.Error())
 		}