fix ISession.CreateTime #173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesposito
reviewed
Apr 22, 2024
| @@ -41,6 +41,7 @@ public async Task ShouldAuthenticateCustomId() | |||
| Assert.NotNull(session.UserId); | |||
| Assert.NotNull(session.Username); | |||
| Assert.False(session.IsExpired); | |||
| Assert.Equal(DateTimeOffset.UtcNow.ToUnixTimeSeconds(), session.CreateTime); | |||
There was a problem hiding this comment.
This may fail if the auth takes 1s to return, shouldn't happen but I wonder if there's a better way of testing time related assertions?
There was a problem hiding this comment.
@sesposito session.CreateTime is actually not returned by the JWT from the server (unless you understand differently?); it's actually set on the session on the client after the server returns. So the chance of the values being unequal would be approx. 1 in a billion on most devs CPUs. That being said, could take a "before authentication" timestamp and "after authentication" timestamp and just ensure that the session.CreateTime falls within the range?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.