Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue with making requests to the gRPC server in the
onSubmitPost
function insrc/pages/NewPost/index.tsx
. The issue was caused by the lack of proper CORS headers in the server's responses, which resulted in the browser blocking the requests.Summary
onSubmitPost
function that makes the gRPC request.console.log('submitting post', draft.text, account);
line with a call to a new functionsubmitPost
that handles the gRPC request.submitPost
function aboveonSubmitPost
to use thegetHubRpcClient
function fromsrc/common/helpers/farcaster.ts
to make the gRPC request.getHubRpcClient
function insrc/common/helpers/farcaster.ts
to use a proxy server that adds the necessary CORS headers to the responses from the gRPC server.This PR ensures that the gRPC requests can be made successfully by handling CORS and allows the web page to access the gRPC server's resources.
Fixes #1.
To checkout this PR branch, run the following command in your terminal:
To get Sweep to edit this pull request, leave a comment below or in the code. Leaving a comment in the code will only modify the file but commenting below can change the entire PR.