Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to Module loaders and package managers, AMD and CommonJS #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

atahdigital
Copy link

Added support to Module loaders and Package managers, AMD and CommonJS.

Added jQuery dependency to package.json.

3 Files affected

  1. package.json
  2. js/jquery.nice-select.js
  3. js/jquery.nice-select.min.js

@hernansartorio
Copy link
Owner

Thank you, but why the tabs?

@atahdigital
Copy link
Author

To lighten the file.
4 spaces was being used for each indentation, so I changed to 1 tab for each indentation.

6kb to 4kb

What do you think, too much? ;)

@hernansartorio
Copy link
Owner

I wouldn't worry about that, I'd rather have the code optimized for readability. Plus for usage in production there's the minified version.

@atahdigital
Copy link
Author

Yes, as I always use tabs for indenting, it was automatic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants