Use hypercall definitions from uhyve-interface #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #1442 |
jounathaen
force-pushed
the
uhyve-interface
branch
2 times, most recently
from
9720732 to
9a16274
Compare
stlankes
approved these changes
Nov 25, 2024
mkroening
requested changes
Nov 26, 2024
jounathaen
force-pushed
the
uhyve-interface
branch
2 times, most recently
from
12eebc9 to
0f6b24b
Compare
|
I hope the latest version has addressed all your comments 🙂 |
jounathaen
force-pushed
the
uhyve-interface
branch
from
0f6b24b to
d98ff02
Compare
jounathaen
force-pushed
the
uhyve-interface
branch
from
d98ff02 to
954098f
Compare
mkroening
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on hermit-os/uhyve#757 (and a publication of uhyve interface V0.1.2)
This is the final step of putting the hypercall definitions in a central crate.
This PR should just deduplicate code without changing functionality.