Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove NASM dependency #494

Merged
merged 1 commit into from
Oct 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,6 @@ jobs:
submodules: true
- uses: mkroening/rust-toolchain-toml@main
- run: rustup component add clippy
- name: Install NASM
run: |
sudo apt-get update
sudo apt-get install nasm
- name: Clippy
run: |
cargo clippy --all-targets
Expand All @@ -44,10 +40,6 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: true
- name: Install NASM
run: |
sudo apt-get update
sudo apt-get install nasm
- uses: mkroening/rust-toolchain-toml@main
- name: Check docs
run: cargo doc --no-deps --document-private-items
Expand All @@ -56,10 +48,10 @@ jobs:
name: KVM
runs-on: [self-hosted]
steps:
- name: Install NASM
- name: Install QEMU
run: |
sudo apt-get update
sudo apt-get install -y nasm qemu-kvm
sudo apt-get install -y qemu-kvm
- uses: actions/checkout@v4
with:
submodules: true
Expand Down Expand Up @@ -140,10 +132,10 @@ jobs:
name: QEMU (x86_64)
runs-on: ubuntu-latest
steps:
- name: Install CURL, QEMU, NASM
- name: Install CURL, QEMU
run: |
sudo apt-get update
sudo apt-get install qemu-system-x86 nasm curl
sudo apt-get install qemu-system-x86 curl
- uses: actions/checkout@v4
with:
submodules: true
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Install NASM
run: |
sudo apt-get update
sudo apt-get install nasm
- uses: actions/checkout@v4
with:
submodules: true
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ Rust applications that use the Rust runtime and do not directly use OS services
## Requirements

* [`rustup`](https://www.rust-lang.org/tools/install)
* [NASM](https://nasm.us/) (only for SMP on x86_64)

## Building your own applications

Expand Down