Add make verify target for running static analysis checks #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybear327
force-pushed
the
feat/add_golangci-lint
branch
6 times, most recently
from
4c53f6f to
c00e611
Compare
Changes: - Introduce `make verify` and `make fmt` targets in Makefile - For linter, use the same config as etcd repo - Update GitHubCI workflow accordingly Closes etcd-io#31 References: - fmt and lint https://github.com/etcd-io/bbolt/blob/c57b3537ed933f2e613f04d42688d49e511f69b3/Makefile#L30C1-L36C84 - fmt script https://github.com/etcd-io/etcd/blob/a08812eb01572aa64479543d1e8fa33cda22b8b8/scripts/fix.sh - GithubCI https://github.com/etcd-io/etcd/blob/a08812eb01572aa64479543d1e8fa33cda22b8b8/.github/workflows/static-analysis.yaml - linter config https://github.com/etcd-io/etcd/blob/a08812eb01572aa64479543d1e8fa33cda22b8b8/tools/.golangci.yaml Signed-off-by: Chun-Hung Tseng <[email protected]>
Signed-off-by: Chun-Hung Tseng <[email protected]>
Signed-off-by: Chun-Hung Tseng <[email protected]>
henrybear327
force-pushed
the
feat/add_golangci-lint
branch
from
c00e611 to
60f0e89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing